You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by pw...@apache.org on 2014/01/23 00:45:14 UTC
[3/3] git commit: Merge pull request #495 from
srowen/GraphXCommonsMathDependency
Merge pull request #495 from srowen/GraphXCommonsMathDependency
Fix graphx Commons Math dependency
`graphx` depends on Commons Math (2.x) in `SVDPlusPlus.scala`. However the module doesn't declare this dependency. It happens to work because it is included by Hadoop artifacts. But, I can tell you this isn't true as of a month or so ago. Building versus recent Hadoop would fail. (That's how we noticed.)
The simple fix is to declare the dependency, as it should be. But it's also worth noting that `commons-math` is the old-ish 2.x line, while `commons-math3` is where newer 3.x releases are. Drop-in replacement, but different artifact and package name. Changing this only usage to `commons-math3` works, tests pass, and isn't surprising that it does, so is probably also worth changing. (A comment in some test code also references `commons-math3`, FWIW.)
It does raise another question though: `mllib` looks like it uses the `jblas` `DoubleMatrix` for general purpose vector/matrix stuff. Should `graphx` really use Commons Math for this? Beyond the tiny scope here but worth asking.
Project: http://git-wip-us.apache.org/repos/asf/incubator-spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-spark/commit/3184facd
Tree: http://git-wip-us.apache.org/repos/asf/incubator-spark/tree/3184facd
Diff: http://git-wip-us.apache.org/repos/asf/incubator-spark/diff/3184facd
Branch: refs/heads/master
Commit: 3184facdc5b1e9ded89133f9b1e4985c9ac78c55
Parents: a1238bb 4476398
Author: Patrick Wendell <pw...@gmail.com>
Authored: Wed Jan 22 15:45:04 2014 -0800
Committer: Patrick Wendell <pw...@gmail.com>
Committed: Wed Jan 22 15:45:04 2014 -0800
----------------------------------------------------------------------
graphx/pom.xml | 5 +++++
.../main/scala/org/apache/spark/graphx/lib/SVDPlusPlus.scala | 2 +-
project/SparkBuild.scala | 5 ++++-
3 files changed, 10 insertions(+), 2 deletions(-)
----------------------------------------------------------------------