You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/13 10:58:42 UTC
[GitHub] [tvm] mikepapadim opened a new pull request #8992: Prevent non-docs stages when a PR only modifies docs/
mikepapadim opened a new pull request #8992:
URL: https://github.com/apache/tvm/pull/8992
This is an intermediate fix for #8673.
It modifies `Jenkinsfile` to prevent non-doc related stages from running when only modifying in `docs/`.
The idea is to save some CI cycles and speed up the process of augmenting docs.
@areusch @comaniac @tqchen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mikepapadim closed pull request #8992: Prevent non-docs stages when a PR only modifies docs/
Posted by GitBox <gi...@apache.org>.
mikepapadim closed pull request #8992:
URL: https://github.com/apache/tvm/pull/8992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on a change in pull request #8992: Prevent non-docs stages when a PR only modifies docs/
Posted by GitBox <gi...@apache.org>.
leandron commented on a change in pull request #8992:
URL: https://github.com/apache/tvm/pull/8992#discussion_r709184555
##########
File path: docker/install/ubuntu_install_vitis_ai_packages_ci.sh
##########
@@ -6,9 +6,9 @@
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
-#
+#
Review comment:
This seems like an unrelated change.
##########
File path: .github/ISSUE_TEMPLATE/documentation.md
##########
@@ -19,4 +19,3 @@ Include the title of the document (e.g. "Getting Started with TVM"), and the typ
If an RFC/discuss post exists, link it here.
Otherwise, specify what actions should be taken to provide additional clarity/readability/reproducibility to the document. Include code snippets from the previous documentation if applicable.
Review comment:
This seems like an unrelated change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mikepapadim commented on pull request #8992: Prevent non-docs stages when a PR only modifies docs/
Posted by GitBox <gi...@apache.org>.
mikepapadim commented on pull request #8992:
URL: https://github.com/apache/tvm/pull/8992#issuecomment-918869901
> @mikepapadim this looks much closer to what we want but I think if I'm reading this right, I see:
>
> * whenever a change only modifies `docs/`, we skip all build, unit test, integration test steps
>
> as @Hzfengsy said, we shouldn't ever skip these nodes:
>
> * Sanity Check (this should already be correct in the patch now)
> * BUILD: GPU
> * docs: GPU
>
> i think we need to find a way to propagate these conditions down to the node level in each stage (e.g. skip each node not listed above when `changeset "docs/**"` doesn't match). i'm not entirely sure how to do this.
Yes, right now the `changeset` condition is in the stage scope, I will have another look on how to make use of it in `node` scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #8992: Prevent non-docs stages when a PR only modifies docs/
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #8992:
URL: https://github.com/apache/tvm/pull/8992#issuecomment-918604587
@mikepapadim this looks much closer to what we want but I think if I'm reading this right, I see:
- whenever a change only modifies `docs/`, we skip all build, unit test, integration test steps
as @Hzfengsy said, we shouldn't ever skip these nodes:
- Sanity Check (this should already be correct in the patch now)
- BUILD: GPU
- docs: GPU
i think we need to find a way to propagate these conditions down to the node level in each stage (e.g. skip each node not listed above when `changeset "docs/**"` doesn't match). i'm not entirely sure how to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Hzfengsy commented on pull request #8992: Prevent non-docs stages when a PR only modifies docs/
Posted by GitBox <gi...@apache.org>.
Hzfengsy commented on pull request #8992:
URL: https://github.com/apache/tvm/pull/8992#issuecomment-918084720
Thanks, @mikepapadim. I agree that it is important to save the CI time.
However, tutorials may be changed even though the codes in `docs/` are not changed. For example, when we change the printer(files in `src/` and `include`) may still change the document. These changes are not often happened but they do exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org