You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/20 19:42:43 UTC

[GitHub] [airflow] ferruzzi commented on a diff in pull request #27039: No extra prefix required for dataprep hook

ferruzzi commented on code in PR #27039:
URL: https://github.com/apache/airflow/pull/27039#discussion_r1001044435


##########
airflow/providers/google/cloud/hooks/dataprep.py:
##########
@@ -29,6 +29,20 @@
 from airflow.hooks.base import BaseHook
 
 
+def _get_field(extras: dict, field_name: str):
+    """Get field from extra, first checking short name, then for backcompat we check for prefixed name."""
+    backcompat_prefix = "extra__dataprep__"
+    if field_name.startswith('extra_'):

Review Comment:
   ```suggestion
       backcompat_prefix = "extra__dataprep__"
       if field_name.startswith(backcompat_prefix):
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org