You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2022/06/08 08:48:41 UTC

[Impala-ASF-CR] WIP IMPALA-5675: Support UTF-8 VARCHAR and CHAR types

Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 )

Change subject: WIP IMPALA-5675: Support UTF-8 VARCHAR and CHAR types
......................................................................


Patch Set 22:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16909/22//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16909/22//COMMIT_MSG@53
PS22, Line 53: Tests:
Can you also add a planner test? The idea is that we should see the effect of utf8ness in the row size in case of char(N). Besides that, I wonder what kind of effect we will see on resource estimates.


http://gerrit.cloudera.org:8080/#/c/16909/22//COMMIT_MSG@57
PS22, Line 57:  - Add tests for writing CHAR(N)/VARCHAR(N) in UTF-8 mode.
Can you also add a test that does compute stats w/wo utf8 mode? I wonder how it affects column stats max/avg length.



-- 
To view, visit http://gerrit.cloudera.org:8080/16909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62efa3042c64d1d005a2cf4fd1d31e992543963f
Gerrit-Change-Number: 16909
Gerrit-PatchSet: 22
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 08:48:41 +0000
Gerrit-HasComments: Yes