You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/13 04:21:42 UTC
[GitHub] [incubator-shardingsphere] zjcnb opened a new pull request #4743:
Amster
zjcnb opened a new pull request #4743: Amster
URL: https://github.com/apache/incubator-shardingsphere/pull/4743
Fixes #4654
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed pull request #4743: add
sql state and vendorCode
Posted by GitBox <gi...@apache.org>.
terrymanu closed pull request #4743: add sql state and vendorCode
URL: https://github.com/apache/incubator-shardingsphere/pull/4743
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] zjcnb commented on issue #4743: add sql
state and vendorCode
Posted by GitBox <gi...@apache.org>.
zjcnb commented on issue #4743: add sql state and vendorCode
URL: https://github.com/apache/incubator-shardingsphere/pull/4743#issuecomment-598546784
> Can you change the title to a whole sentence for search friendly?
ok. i done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull
request #4743: Amster
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4743: Amster
URL: https://github.com/apache/incubator-shardingsphere/pull/4743#discussion_r392026790
##########
File path: sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/resultset/ShardingResultSetMetaData.java
##########
@@ -35,65 +36,64 @@
*/
@RequiredArgsConstructor
public final class ShardingResultSetMetaData extends WrapperAdapter implements ResultSetMetaData {
-
+
Review comment:
Could you keep the original indent?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue
#4743: Amster
Posted by GitBox <gi...@apache.org>.
terrymanu edited a comment on issue #4743: Amster
URL: https://github.com/apache/incubator-shardingsphere/pull/4743#issuecomment-598544353
It is not make sense for your commit logs.
Could you reference the contributor guide to make a clear develop flow of commit?
FIY: https://shardingsphere.apache.org/community/en/contribute/contributor/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull
request #4743: Amster
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4743: Amster
URL: https://github.com/apache/incubator-shardingsphere/pull/4743#discussion_r392026833
##########
File path: sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/constant/SQLExceptionConstant.java
##########
@@ -25,6 +25,10 @@
*/
@NoArgsConstructor(access = AccessLevel.PRIVATE)
public final class SQLExceptionConstant {
-
+
Review comment:
Could you keep the original indent?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4743: add
sql state and vendorCode
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #4743: add sql state and vendorCode
URL: https://github.com/apache/incubator-shardingsphere/pull/4743#issuecomment-598817857
Because the commit log is not clean for this pr. I just colse it, please submit a new pr with clean commit log.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4743:
Amster
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #4743: Amster
URL: https://github.com/apache/incubator-shardingsphere/pull/4743#issuecomment-598544353
The commit log is not make sense, could you reference the contributor guide to make a clear develop flow of commit?
FIY: https://shardingsphere.apache.org/community/en/contribute/contributor/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services