You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2023/12/10 11:33:24 UTC

(maven-reporting-impl) 01/02: [MSHARED-1327] Change default value of output directory in AbstractMavenReport

This is an automated email from the ASF dual-hosted git repository.

michaelo pushed a commit to branch MSHARED-1343
in repository https://gitbox.apache.org/repos/asf/maven-reporting-impl.git

commit c8d4e89f03793674bf4de67455183ae816f67f81
Author: Alexander Kriegisch <Al...@Kriegisch.name>
AuthorDate: Mon Oct 23 08:17:58 2023 +0700

    [MSHARED-1327] Change default value of output directory in AbstractMavenReport
    
    The output directory now defaults to ${project.build.directory}/reports
    instead of ${project.reporting.outputDirectory}.
    This represents a clear separatation between standalone invocation compared to
    site generation.
    
    This closes #26
---
 src/it/use-as-direct-mojo-markup/verify.groovy                    | 2 +-
 src/it/use-as-direct-mojo/verify.groovy                           | 2 +-
 src/main/java/org/apache/maven/reporting/AbstractMavenReport.java | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/it/use-as-direct-mojo-markup/verify.groovy b/src/it/use-as-direct-mojo-markup/verify.groovy
index 2bb2483..c4a6bc3 100644
--- a/src/it/use-as-direct-mojo-markup/verify.groovy
+++ b/src/it/use-as-direct-mojo-markup/verify.groovy
@@ -17,7 +17,7 @@
  * under the License.
  */
 
-File outputDir = new File( basedir, 'target/site/' )
+File outputDir = new File( basedir, 'target/reports/' )
 
 File f = new File( outputDir, 'custom-report.xdoc' );
 assert f.exists();
diff --git a/src/it/use-as-direct-mojo/verify.groovy b/src/it/use-as-direct-mojo/verify.groovy
index 3e4f303..32533e4 100644
--- a/src/it/use-as-direct-mojo/verify.groovy
+++ b/src/it/use-as-direct-mojo/verify.groovy
@@ -17,7 +17,7 @@
  * under the License.
  */
 
-File outputDir = new File( basedir, 'target/site/' )
+File outputDir = new File( basedir, 'target/reports/' )
 
 File f = new File( outputDir, 'custom-report.html' );
 assert f.exists();
diff --git a/src/main/java/org/apache/maven/reporting/AbstractMavenReport.java b/src/main/java/org/apache/maven/reporting/AbstractMavenReport.java
index fa27731..d48e3f1 100644
--- a/src/main/java/org/apache/maven/reporting/AbstractMavenReport.java
+++ b/src/main/java/org/apache/maven/reporting/AbstractMavenReport.java
@@ -84,7 +84,7 @@ public abstract class AbstractMavenReport extends AbstractMojo implements MavenM
      * user-defined mojo parameter with a default value) to generate multi-page reports or external reports with the
      * main output file (entry point) denoted by {@link #getOutputName()}.
      */
-    @Parameter(defaultValue = "${project.reporting.outputDirectory}", readonly = true, required = true)
+    @Parameter(defaultValue = "${project.build.directory}/reports", readonly = true, required = true)
     protected File outputDirectory;
 
     /**