You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Joe Bowser (JIRA)" <ji...@apache.org> on 2012/07/24 01:13:33 UTC

[jira] [Created] (CB-1109) Migrate to

Joe Bowser created CB-1109:
------------------------------

             Summary: Migrate <plugin> to <feature>
                 Key: CB-1109
                 URL: https://issues.apache.org/jira/browse/CB-1109
             Project: Apache Cordova
          Issue Type: Sub-task
            Reporter: Joe Bowser




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CB-1109) Migrate to

Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CB-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe Bowser updated CB-1109:
---------------------------

          Component/s: WP7
                       iOS
                       BlackBerry
                       Bada
                       Android
    Affects Version/s: 2.1.0
    
> Migrate <plugin> to <feature>
> -----------------------------
>
>                 Key: CB-1109
>                 URL: https://issues.apache.org/jira/browse/CB-1109
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Android, Bada, BlackBerry, iOS, WP7
>    Affects Versions: 2.1.0
>            Reporter: Joe Bowser
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CB-1109) Migrate to

Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421035#comment-13421035 ] 

Joe Bowser commented on CB-1109:
--------------------------------

Would that still conform to the spec?  It seems that name/value pairs must be inside in the params.
                
> Migrate <plugin> to <feature>
> -----------------------------
>
>                 Key: CB-1109
>                 URL: https://issues.apache.org/jira/browse/CB-1109
>             Project: Apache Cordova
>          Issue Type: Sub-task
>            Reporter: Joe Bowser
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CB-1109) Migrate to

Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450117#comment-13450117 ] 

Joe Bowser commented on CB-1109:
--------------------------------

Apparently it was cool a month ago, adding to Android.
                
> Migrate <plugin> to <feature>
> -----------------------------
>
>                 Key: CB-1109
>                 URL: https://issues.apache.org/jira/browse/CB-1109
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Android, Bada, BlackBerry, iOS, WP7
>    Affects Versions: 2.1.0
>            Reporter: Joe Bowser
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CB-1109) Migrate to

Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CB-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe Bowser updated CB-1109:
---------------------------

    Component/s:     (was: Android)
    
> Migrate <plugin> to <feature>
> -----------------------------
>
>                 Key: CB-1109
>                 URL: https://issues.apache.org/jira/browse/CB-1109
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Bada, BlackBerry, iOS, WP7
>    Affects Versions: 2.1.0
>            Reporter: Joe Bowser
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CB-1109) Migrate to

Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456108#comment-13456108 ] 

Joe Bowser commented on CB-1109:
--------------------------------

Yes, it was: 
https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=commit;h=8013b760e3c63528638246d2c3c019d9bf8025b5
https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=commit;h=d4b248fbe37236c6dda18e095b1a8816b682774e

Here's where I decide to use the old feature for 2.1:
https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=commit;h=c6fa7e4aade2998c0dc53c6135c1be7138d2f9f5

                
> Migrate <plugin> to <feature>
> -----------------------------
>
>                 Key: CB-1109
>                 URL: https://issues.apache.org/jira/browse/CB-1109
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Bada, BlackBerry, iOS, WP7
>    Affects Versions: 2.1.0
>            Reporter: Joe Bowser
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CB-1109) Migrate to

Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421043#comment-13421043 ] 

Filip Maj commented on CB-1109:
-------------------------------

Its wordy but its conformant and does what we need.
                
> Migrate <plugin> to <feature>
> -----------------------------
>
>                 Key: CB-1109
>                 URL: https://issues.apache.org/jira/browse/CB-1109
>             Project: Apache Cordova
>          Issue Type: Sub-task
>            Reporter: Joe Bowser
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Comment Edited] (CB-1109) Migrate to

Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421025#comment-13421025 ] 

Joe Bowser edited comment on CB-1109 at 7/23/12 11:26 PM:
----------------------------------------------------------

Unlike plugin, which is platform-specific and specifies the namespace, feature will have to contain params which define the service, the package, and other methods.

{code}
<feature name="http://example.com/testUri">
<param name="service" value="TestPlugin" />
<param name="package" value="org.cordova.test.TestPlugin" />
</feature>
{code}
                
      was (Author: bowserj):
    Unlike plugin, which is platform-specific and specifies the namespace, feature will have to contain params which define the service, the package, and other methods.

{{{
<feature name="http://example.com/testUri">
<param name="service" value="TestPlugin" />
<param name="package" value="org.cordova.test.TestPlugin" />
</feature>
}}}
                  
> Migrate <plugin> to <feature>
> -----------------------------
>
>                 Key: CB-1109
>                 URL: https://issues.apache.org/jira/browse/CB-1109
>             Project: Apache Cordova
>          Issue Type: Sub-task
>            Reporter: Joe Bowser
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CB-1109) Migrate to

Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421037#comment-13421037 ] 

Filip Maj commented on CB-1109:
-------------------------------

Not sure haha
                
> Migrate <plugin> to <feature>
> -----------------------------
>
>                 Key: CB-1109
>                 URL: https://issues.apache.org/jira/browse/CB-1109
>             Project: Apache Cordova
>          Issue Type: Sub-task
>            Reporter: Joe Bowser
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CB-1109) Migrate to

Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450105#comment-13450105 ] 

Joe Bowser commented on CB-1109:
--------------------------------

Hey

Is it cool if I merge this in? 
https://github.com/infil00p/callback-android/commit/8013b760e3c63528638246d2c3c019d9bf8025b5
                
> Migrate <plugin> to <feature>
> -----------------------------
>
>                 Key: CB-1109
>                 URL: https://issues.apache.org/jira/browse/CB-1109
>             Project: Apache Cordova
>          Issue Type: Sub-task
>            Reporter: Joe Bowser
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CB-1109) Migrate to

Posted by "Braden Shepherdson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456064#comment-13456064 ] 

Braden Shepherdson commented on CB-1109:
----------------------------------------

Joe, what's the state of your Android change? It seems like it was never merged from your side repo.
                
> Migrate <plugin> to <feature>
> -----------------------------
>
>                 Key: CB-1109
>                 URL: https://issues.apache.org/jira/browse/CB-1109
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Bada, BlackBerry, iOS, WP7
>    Affects Versions: 2.1.0
>            Reporter: Joe Bowser
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CB-1109) Migrate to

Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421029#comment-13421029 ] 

Filip Maj commented on CB-1109:
-------------------------------

Could we simply use the {{name}} attribute inside the {{<feature>}} and get rid of the {{<param name="service" />}} element?
                
> Migrate <plugin> to <feature>
> -----------------------------
>
>                 Key: CB-1109
>                 URL: https://issues.apache.org/jira/browse/CB-1109
>             Project: Apache Cordova
>          Issue Type: Sub-task
>            Reporter: Joe Bowser
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CB-1109) Migrate to

Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421044#comment-13421044 ] 

Joe Bowser commented on CB-1109:
--------------------------------

I know it's wordy, but after thinking about this, this might be better because we can pass additional launch params to plugins and allow the user to define things declaratively.  The more I see it, the more I'm on the fence.
                
> Migrate <plugin> to <feature>
> -----------------------------
>
>                 Key: CB-1109
>                 URL: https://issues.apache.org/jira/browse/CB-1109
>             Project: Apache Cordova
>          Issue Type: Sub-task
>            Reporter: Joe Bowser
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CB-1109) Migrate to

Posted by "Brian LeRoux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421042#comment-13421042 ] 

Brian LeRoux commented on CB-1109:
----------------------------------

Keeping in mind spec conformance is the right thing to do here, creating a new one exacerbates the problem the project is looking to solve, looks like the way you describe would be the closest Joe. That said, we could propose sane alternatives. Name/value pairs in XML not really all that sane but I can get why they did it that way.

http://www.w3.org/TR/widgets/#the-feature-element-and-its-attributes
                
> Migrate <plugin> to <feature>
> -----------------------------
>
>                 Key: CB-1109
>                 URL: https://issues.apache.org/jira/browse/CB-1109
>             Project: Apache Cordova
>          Issue Type: Sub-task
>            Reporter: Joe Bowser
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CB-1109) Migrate to

Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421025#comment-13421025 ] 

Joe Bowser commented on CB-1109:
--------------------------------

Unlike plugin, which is platform-specific and specifies the namespace, feature will have to contain params which define the service, the package, and other methods.

{{{
<feature name="http://example.com/testUri">
<param name="service" value="TestPlugin" />
<param name="package" value="org.cordova.test.TestPlugin" />
</feature>
}}}
                
> Migrate <plugin> to <feature>
> -----------------------------
>
>                 Key: CB-1109
>                 URL: https://issues.apache.org/jira/browse/CB-1109
>             Project: Apache Cordova
>          Issue Type: Sub-task
>            Reporter: Joe Bowser
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira