You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Saksham Srivastava <sa...@citrix.com> on 2014/03/03 14:57:03 UTC
Re: Review Request 18352: CLOUDSTACK-6151: Local data disk with tag goes to
the wrong local storage pool
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18352/
-----------------------------------------------------------
(Updated March 3, 2014, 1:57 p.m.)
Review request for cloudstack, Koushik Das and Prachi Damle.
Bugs: CLOUDSTACK-6151
https://issues.apache.org/jira/browse/CLOUDSTACK-6151
Repository: cloudstack-git
Description (updated)
-------
Attaching a new disk created from local disk offering with tags, to a VM was going to wrong local storage pool.
Cause : In LocalStoragePoolAlocator-
List<StoragePoolHostVO> hostPools = _poolHostDao.listByHostId(plan.getHostId());
It return pools by hostId, but nowhere were the tags being compared.
Added new method findLocalStoragePoolsByHostAndTags() that returns stoage pools by hostid and tags both.
Diffs (updated)
-----
engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml ea0bad9
engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java 59c338e
engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java d35aa44
engine/storage/src/org/apache/cloudstack/storage/allocator/LocalStoragePoolAllocator.java 1f61e8b
server/test/resources/createNetworkOffering.xml c6228da
Diff: https://reviews.apache.org/r/18352/diff/
Testing (updated)
-------
Tested the folowing scenarios:
attaching local volume with tags
attaching local volume without tags
attaching local volume with different tags
attaching shared volume
Build passes successfully.
Patch applies cleanly.
Thanks,
Saksham Srivastava
Re: Review Request 18352: CLOUDSTACK-6151: Local data disk with tag goes to
the wrong local storage pool
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18352/#review36215
-----------------------------------------------------------
Ship it!
Ship It!
- Koushik Das
On March 5, 2014, 8:50 a.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18352/
> -----------------------------------------------------------
>
> (Updated March 5, 2014, 8:50 a.m.)
>
>
> Review request for cloudstack, Koushik Das and Prachi Damle.
>
>
> Bugs: CLOUDSTACK-6151
> https://issues.apache.org/jira/browse/CLOUDSTACK-6151
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Attaching a new disk created from local disk offering with tags, to a VM was going to wrong local storage pool.
> Cause : In LocalStoragePoolAlocator-
> List<StoragePoolHostVO> hostPools = _poolHostDao.listByHostId(plan.getHostId());
> It return pools by hostId, but nowhere were the tags being compared.
>
> Added new method findLocalStoragePoolsByHostAndTags() that returns stoage pools by hostid and tags both.
>
>
> Diffs
> -----
>
> engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml ea0bad9
> engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java 59c338e
> engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java d35aa44
> engine/storage/src/org/apache/cloudstack/storage/allocator/LocalStoragePoolAllocator.java 1f61e8b
> server/test/resources/createNetworkOffering.xml c6228da
>
> Diff: https://reviews.apache.org/r/18352/diff/
>
>
> Testing
> -------
>
> Tested the folowing scenarios:
> attaching local volume with tags
> attaching local volume without tags
> attaching local volume with different tags
> attaching shared volume
>
> Build passes successfully.
> Patch applies cleanly.
>
>
> Thanks,
>
> Saksham Srivastava
>
>
Re: Review Request 18352: CLOUDSTACK-6151: Local data disk with tag goes to
the wrong local storage pool
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18352/#review36214
-----------------------------------------------------------
Commit a8b34c0c4f99067243524813f136b31cb78c5f78 in cloudstack's branch refs/heads/4.3-forward from Saksham Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a8b34c0 ]
CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool
Signed-off-by: Koushik Das <ko...@apache.org>
- ASF Subversion and Git Services
On March 5, 2014, 8:50 a.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18352/
> -----------------------------------------------------------
>
> (Updated March 5, 2014, 8:50 a.m.)
>
>
> Review request for cloudstack, Koushik Das and Prachi Damle.
>
>
> Bugs: CLOUDSTACK-6151
> https://issues.apache.org/jira/browse/CLOUDSTACK-6151
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Attaching a new disk created from local disk offering with tags, to a VM was going to wrong local storage pool.
> Cause : In LocalStoragePoolAlocator-
> List<StoragePoolHostVO> hostPools = _poolHostDao.listByHostId(plan.getHostId());
> It return pools by hostId, but nowhere were the tags being compared.
>
> Added new method findLocalStoragePoolsByHostAndTags() that returns stoage pools by hostid and tags both.
>
>
> Diffs
> -----
>
> engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml ea0bad9
> engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java 59c338e
> engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java d35aa44
> engine/storage/src/org/apache/cloudstack/storage/allocator/LocalStoragePoolAllocator.java 1f61e8b
> server/test/resources/createNetworkOffering.xml c6228da
>
> Diff: https://reviews.apache.org/r/18352/diff/
>
>
> Testing
> -------
>
> Tested the folowing scenarios:
> attaching local volume with tags
> attaching local volume without tags
> attaching local volume with different tags
> attaching shared volume
>
> Build passes successfully.
> Patch applies cleanly.
>
>
> Thanks,
>
> Saksham Srivastava
>
>
Re: Review Request 18352: CLOUDSTACK-6151: Local data disk with tag goes to
the wrong local storage pool
Posted by Saksham Srivastava <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18352/
-----------------------------------------------------------
(Updated March 5, 2014, 8:50 a.m.)
Review request for cloudstack, Koushik Das and Prachi Damle.
Bugs: CLOUDSTACK-6151
https://issues.apache.org/jira/browse/CLOUDSTACK-6151
Repository: cloudstack-git
Description
-------
Attaching a new disk created from local disk offering with tags, to a VM was going to wrong local storage pool.
Cause : In LocalStoragePoolAlocator-
List<StoragePoolHostVO> hostPools = _poolHostDao.listByHostId(plan.getHostId());
It return pools by hostId, but nowhere were the tags being compared.
Added new method findLocalStoragePoolsByHostAndTags() that returns stoage pools by hostid and tags both.
Diffs (updated)
-----
engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml ea0bad9
engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java 59c338e
engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java d35aa44
engine/storage/src/org/apache/cloudstack/storage/allocator/LocalStoragePoolAllocator.java 1f61e8b
server/test/resources/createNetworkOffering.xml c6228da
Diff: https://reviews.apache.org/r/18352/diff/
Testing
-------
Tested the folowing scenarios:
attaching local volume with tags
attaching local volume without tags
attaching local volume with different tags
attaching shared volume
Build passes successfully.
Patch applies cleanly.
Thanks,
Saksham Srivastava