You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by fj...@apache.org on 2018/08/27 01:59:04 UTC
[incubator-druid] branch master updated: Fix timeout in
KafkaSupervisorTest.testCheckpointForInactiveTaskGroup (#6207)
This is an automated email from the ASF dual-hosted git repository.
fjy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new 64d33ee Fix timeout in KafkaSupervisorTest.testCheckpointForInactiveTaskGroup (#6207)
64d33ee is described below
commit 64d33eef7e85e39907cbfa94517f6aecf6288023
Author: Jihoon Son <ji...@apache.org>
AuthorDate: Sun Aug 26 18:59:01 2018 -0700
Fix timeout in KafkaSupervisorTest.testCheckpointForInactiveTaskGroup (#6207)
* Fix timeout in KafkaSupervisorTest.testCheckpointForInactiveTaskGroup
* fix npe
* add taskRunner.getRunningTasks()
---
.../indexing/kafka/supervisor/KafkaSupervisorTest.java | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/extensions-core/kafka-indexing-service/src/test/java/io/druid/indexing/kafka/supervisor/KafkaSupervisorTest.java b/extensions-core/kafka-indexing-service/src/test/java/io/druid/indexing/kafka/supervisor/KafkaSupervisorTest.java
index 4d062d8..8937f60 100644
--- a/extensions-core/kafka-indexing-service/src/test/java/io/druid/indexing/kafka/supervisor/KafkaSupervisorTest.java
+++ b/extensions-core/kafka-indexing-service/src/test/java/io/druid/indexing/kafka/supervisor/KafkaSupervisorTest.java
@@ -2061,6 +2061,14 @@ public class KafkaSupervisorTest extends EasyMockSupport
null
);
+ final TaskLocation location1 = new TaskLocation("testHost", 1234, -1);
+ final TaskLocation location2 = new TaskLocation("testHost2", 145, -1);
+ Collection workItems = new ArrayList<>();
+ workItems.add(new TestTaskRunnerWorkItem(id1, null, location1));
+ workItems.add(new TestTaskRunnerWorkItem(id2, null, location2));
+ workItems.add(new TestTaskRunnerWorkItem(id2, null, location2));
+
+ expect(taskRunner.getRunningTasks()).andReturn(workItems).anyTimes();
expect(taskMaster.getTaskQueue()).andReturn(Optional.of(taskQueue)).anyTimes();
expect(taskMaster.getTaskRunner()).andReturn(Optional.of(taskRunner)).anyTimes();
expect(taskStorage.getActiveTasks()).andReturn(ImmutableList.of(id1, id2, id3)).anyTimes();
@@ -2115,12 +2123,8 @@ public class KafkaSupervisorTest extends EasyMockSupport
verifyAll();
- while (serviceEmitter.getStackTrace() != null) {
- Thread.sleep(100);
- }
-
- Assert.assertNull(serviceEmitter.getStackTrace());
- Assert.assertNull(serviceEmitter.getExceptionMessage());
+ Assert.assertNull(serviceEmitter.getStackTrace(), serviceEmitter.getStackTrace());
+ Assert.assertNull(serviceEmitter.getExceptionMessage(), serviceEmitter.getExceptionMessage());
Assert.assertNull(serviceEmitter.getExceptionClass());
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org