You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "jlprat (via GitHub)" <gi...@apache.org> on 2023/05/11 08:56:24 UTC

[GitHub] [kafka] jlprat opened a new pull request, #13706: MINOR: clean up unused methods in core utils

jlprat opened a new pull request, #13706:
URL: https://github.com/apache/kafka/pull/13706

   Inspired by https://github.com/apache/kafka/pull/13170 I decided to check some other core utils classes and remove some unused methods.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] jlprat commented on pull request #13706: MINOR: clean up unused methods in core utils

Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #13706:
URL: https://github.com/apache/kafka/pull/13706#issuecomment-1544246745

   All test failures seem to be unrelated to the change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] jlprat commented on pull request #13706: MINOR: clean up unused methods in core utils

Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #13706:
URL: https://github.com/apache/kafka/pull/13706#issuecomment-1543873607

   Thanks @machi1990 I fixed the typo as well


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] jlprat merged pull request #13706: MINOR: clean up unused methods in core utils

Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat merged PR #13706:
URL: https://github.com/apache/kafka/pull/13706


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] jlprat commented on pull request #13706: MINOR: clean up unused methods in core utils

Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #13706:
URL: https://github.com/apache/kafka/pull/13706#issuecomment-1543608786

   @mimaison I took inspiration from your PR to clean up some more unused methods


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org