You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Cheolsoo Park <ch...@cloudera.com> on 2012/06/20 09:07:43 UTC
Review Request: SQOOP-505 Trailing space after jar in managers.d/connectors
causes file not found
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5432/
-----------------------------------------------------------
Review request for Sqoop, Jarek Cecho and Bilung Lee.
Description
-------
Whitespace should be trimmed when the property file is loaded.
This addresses bug SQOOP-505.
https://issues.apache.org/jira/browse/SQOOP-505
Diffs
-----
/src/java/org/apache/sqoop/ConnFactory.java 1351937
Diff: https://reviews.apache.org/r/5432/diff/
Testing
-------
ant test, ant test -Dthirdparty=true, and ant checkstyle.
Thanks,
Cheolsoo Park
Re: Review Request: SQOOP-505 Trailing space after jar in
managers.d/connectors causes file not found
Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5432/#review8435
-----------------------------------------------------------
Ship it!
Thanks for the fix. +1.
- Bilung Lee
On June 20, 2012, 9:58 p.m., Cheolsoo Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5432/
> -----------------------------------------------------------
>
> (Updated June 20, 2012, 9:58 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho and Bilung Lee.
>
>
> Description
> -------
>
> Whitespace should be trimmed when the property file is loaded.
>
>
> This addresses bug SQOOP-505.
> https://issues.apache.org/jira/browse/SQOOP-505
>
>
> Diffs
> -----
>
> /src/java/org/apache/sqoop/ConnFactory.java 1351937
>
> Diff: https://reviews.apache.org/r/5432/diff/
>
>
> Testing
> -------
>
> 1) ant test, ant test -Dthirdparty=true, and ant checkstyle.
>
> 2) Tested using Teradata connector with the following 'connector' file:
>
> <some space>com.cloudera.sqoop.manager.TeradataManagerFactory<some space>=<some space>/home/cheolsoo/workspace/sqoop_505/sqoop-td-connector-1.0.5/sqoop-td-connector-1.0.5.jar<some space>
>
>
> Thanks,
>
> Cheolsoo Park
>
>
Re: Review Request: SQOOP-505 Trailing space after jar in
managers.d/connectors causes file not found
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5432/
-----------------------------------------------------------
(Updated June 20, 2012, 9:58 p.m.)
Review request for Sqoop, Jarek Cecho and Bilung Lee.
Changes
-------
Incorporate Bilung's comment.
Description
-------
Whitespace should be trimmed when the property file is loaded.
This addresses bug SQOOP-505.
https://issues.apache.org/jira/browse/SQOOP-505
Diffs (updated)
-----
/src/java/org/apache/sqoop/ConnFactory.java 1351937
Diff: https://reviews.apache.org/r/5432/diff/
Testing
-------
1) ant test, ant test -Dthirdparty=true, and ant checkstyle.
2) Tested using Teradata connector with the following 'connector' file:
<some space>com.cloudera.sqoop.manager.TeradataManagerFactory<some space>=<some space>/home/cheolsoo/workspace/sqoop_505/sqoop-td-connector-1.0.5/sqoop-td-connector-1.0.5.jar<some space>
Thanks,
Cheolsoo Park
Re: Review Request: SQOOP-505 Trailing space after jar in
managers.d/connectors causes file not found
Posted by Cheolsoo Park <ch...@cloudera.com>.
> On June 20, 2012, 9:25 p.m., Bilung Lee wrote:
> > /src/java/org/apache/sqoop/ConnFactory.java, line 152
> > <https://reviews.apache.org/r/5432/diff/1/?file=112402#file112402line152>
> >
> > The code here doesn't handle the case with "=" in the path (which may not be that common though). It may be better to get the key-value pair simply based on the first appearance of "=".
Good catch. I will fix it. Thanks a lot Bilung!
- Cheolsoo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5432/#review8429
-----------------------------------------------------------
On June 20, 2012, 7:17 p.m., Cheolsoo Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5432/
> -----------------------------------------------------------
>
> (Updated June 20, 2012, 7:17 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho and Bilung Lee.
>
>
> Description
> -------
>
> Whitespace should be trimmed when the property file is loaded.
>
>
> This addresses bug SQOOP-505.
> https://issues.apache.org/jira/browse/SQOOP-505
>
>
> Diffs
> -----
>
> /src/java/org/apache/sqoop/ConnFactory.java 1351937
>
> Diff: https://reviews.apache.org/r/5432/diff/
>
>
> Testing
> -------
>
> 1) ant test, ant test -Dthirdparty=true, and ant checkstyle.
>
> 2) Tested using Teradata connector with the following 'connector' file:
>
> <some space>com.cloudera.sqoop.manager.TeradataManagerFactory<some space>=<some space>/home/cheolsoo/workspace/sqoop_505/sqoop-td-connector-1.0.5/sqoop-td-connector-1.0.5.jar<some space>
>
>
> Thanks,
>
> Cheolsoo Park
>
>
Re: Review Request: SQOOP-505 Trailing space after jar in
managers.d/connectors causes file not found
Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5432/#review8429
-----------------------------------------------------------
One comment below.
/src/java/org/apache/sqoop/ConnFactory.java
<https://reviews.apache.org/r/5432/#comment18109>
The code here doesn't handle the case with "=" in the path (which may not be that common though). It may be better to get the key-value pair simply based on the first appearance of "=".
- Bilung Lee
On June 20, 2012, 7:17 p.m., Cheolsoo Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5432/
> -----------------------------------------------------------
>
> (Updated June 20, 2012, 7:17 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho and Bilung Lee.
>
>
> Description
> -------
>
> Whitespace should be trimmed when the property file is loaded.
>
>
> This addresses bug SQOOP-505.
> https://issues.apache.org/jira/browse/SQOOP-505
>
>
> Diffs
> -----
>
> /src/java/org/apache/sqoop/ConnFactory.java 1351937
>
> Diff: https://reviews.apache.org/r/5432/diff/
>
>
> Testing
> -------
>
> 1) ant test, ant test -Dthirdparty=true, and ant checkstyle.
>
> 2) Tested using Teradata connector with the following 'connector' file:
>
> <some space>com.cloudera.sqoop.manager.TeradataManagerFactory<some space>=<some space>/home/cheolsoo/workspace/sqoop_505/sqoop-td-connector-1.0.5/sqoop-td-connector-1.0.5.jar<some space>
>
>
> Thanks,
>
> Cheolsoo Park
>
>
Re: Review Request: SQOOP-505 Trailing space after jar in
managers.d/connectors causes file not found
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5432/
-----------------------------------------------------------
(Updated June 20, 2012, 7:17 p.m.)
Review request for Sqoop, Jarek Cecho and Bilung Lee.
Description
-------
Whitespace should be trimmed when the property file is loaded.
This addresses bug SQOOP-505.
https://issues.apache.org/jira/browse/SQOOP-505
Diffs
-----
/src/java/org/apache/sqoop/ConnFactory.java 1351937
Diff: https://reviews.apache.org/r/5432/diff/
Testing (updated)
-------
1) ant test, ant test -Dthirdparty=true, and ant checkstyle.
2) Tested using Teradata connector with the following 'connector' file:
<some space>com.cloudera.sqoop.manager.TeradataManagerFactory<some space>=<some space>/home/cheolsoo/workspace/sqoop_505/sqoop-td-connector-1.0.5/sqoop-td-connector-1.0.5.jar<some space>
Thanks,
Cheolsoo Park