[GitHub] [kafka] C0urante commented on pull request #13163: KAFKA-14653: MirrorMakerConfig using raw properties instead of post-r…

["C0urante (via GitHub)" <gi...@apache.org>]

C0urante commented on PR #13163:
URL: https://github.com/apache/kafka/pull/13163#issuecomment-1430077887

   @urbandan Ah yes, apologies for missing that. You're right, we don't need any more coverage for the `MirrorMakerConfig` class.
   
   I also agree that the manual config transformations performed by that class appear to be unnecessary. I'm a little hesitant to remove them since I haven't been able to find out why they were added that way in the first place (I checked the original MM2 KIP and PR, but couldn't find anything relevant, and the `ConfigProvider` mechanism was added to the `AbstractConfig` class in version 2.3.0, one release earlier than MM2, which came out in 2.4.0). I guess it's possible that the PR for MM2 was written before the `ConfigProvider` logic was added to the `AbstractConfig` class, and the manual transformation slipped through during review?
   
   Anyways, I think it'd be best to leave it to a follow-up PR if we wanted to remove that logic. That way, if there is any unintended fallout, we can just revert that commit without worrying about also undoing the work necessary for KIP-710.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org