You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Blake Eggleston (JIRA)" <ji...@apache.org> on 2016/07/18 16:40:20 UTC

[jira] [Commented] (CASSANDRA-9054) Break DatabaseDescriptor up into multiple classes.

    [ https://issues.apache.org/jira/browse/CASSANDRA-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382551#comment-15382551 ] 

Blake Eggleston commented on CASSANDRA-9054:
--------------------------------------------

What about _actually_ breaking DatabaseDescriptor into a few different config classes? The patch here does fix the specific bits of code causing problems on startup, but we still have this huge god object that's hooked into everything. 

Do you have any thoughts here [~yukim]? I know you've wanted to do something similar for a while now.

> Break DatabaseDescriptor up into multiple classes.
> --------------------------------------------------
>
>                 Key: CASSANDRA-9054
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9054
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jeremiah Jordan
>            Assignee: Robert Stupp
>             Fix For: 3.x
>
>
> Right now to get at Config stuff you go through DatabaseDescriptor.  But when you instantiate DatabaseDescriptor it actually opens system tables and such, which triggers commit log replays, and other things if the right flags aren't set ahead of time.  This makes getting at config stuff from tools annoying, as you have to be very careful about instantiation orders.
> It would be nice if we could break DatabaseDescriptor up into multiple classes, so that getting at config stuff from tools wasn't such a pain.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)