You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/06/09 14:55:50 UTC

[GitHub] [incubator-shenyu] dragon-zhang commented on a diff in pull request #3503: #3407 add the logic of annotation on the splicing class for tars client

dragon-zhang commented on code in PR #3503:
URL: https://github.com/apache/incubator-shenyu/pull/3503#discussion_r893611376


##########
shenyu-client/shenyu-client-tars/src/main/java/org/apache/shenyu/client/tars/TarsServiceBeanPostProcessor.java:
##########
@@ -91,7 +97,17 @@ private void handler(final Object serviceBean) {
             clazz = AopUtils.getTargetClass(serviceBean);
         }
         Method[] methods = ReflectionUtils.getUniqueDeclaredMethods(clazz);
-        String serviceName = clazz.getAnnotation(ShenyuTarsService.class).serviceName();
+        ShenyuTarsService shenyuTarsService = clazz.getAnnotation(ShenyuTarsService.class);
+        String serviceName = shenyuTarsService.serviceName();

Review Comment:
   missed `ShenyuTarsClient beanShenyuTarsClient = clazz.getAnnotation(ShenyuTarsClient.class);`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org