You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/16 03:18:14 UTC

[GitHub] [flink] wangyang0918 commented on a change in pull request #10550: [FLINK-15194] Support registering directory as cache file in Yarn per-job mode

wangyang0918 commented on a change in pull request #10550: [FLINK-15194] Support registering directory as cache file in Yarn per-job mode
URL: https://github.com/apache/flink/pull/10550#discussion_r358039336
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
 ##########
 @@ -286,10 +286,12 @@ public Path call() throws IOException {
 		private final Path filePath;
 		private final Path cachedPath;
 		private boolean executable;
+		private final boolean isDirectory;
 
 		public CopyFromDFSProcess(DistributedCacheEntry e, Path cachedPath) {
 			this.filePath = new Path(e.filePath);
 			this.executable = e.isExecutable;
+			this.isDirectory = e.isZipped;
 
 Review comment:
   I will rename to `isZipped`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services