You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2021/11/28 09:22:54 UTC
[GitHub] [incubator-inlong] healchow opened a new pull request #1850: [INLONG-1849][Feature][InLong-Manager] Push Pulsar info for Sort
healchow opened a new pull request #1850:
URL: https://github.com/apache/incubator-inlong/pull/1850
### Title Name: [INLONG-1849][Feature][InLong-Manager] Push Pulsar info for Sort
Fixes #1849
### Motivation
Push Pulsar info for Sort.
### Modifications
Add table fields for Pulsar, and support push Pulsar info for Sort.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
### Documentation
- Does this pull request introduces a new feature? no
- If yes, how is the feature documented? JavaDocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter edited a comment on pull request #1850: [INLONG-1849][Feature][InLong-Manager] Push Pulsar info for Sort
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1850:
URL: https://github.com/apache/incubator-inlong/pull/1850#issuecomment-981052841
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1850?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1850](https://codecov.io/gh/apache/incubator-inlong/pull/1850?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c7b0b3) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/13d07a30771311548ce9ce35e1aa8eb5878009ad?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (13d07a3) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-inlong/pull/1850?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1850 +/- ##
=========================================
Coverage 11.53% 11.53%
Complexity 1049 1049
=========================================
Files 400 400
Lines 34789 34789
Branches 5504 5504
=========================================
Hits 4013 4013
Misses 30009 30009
Partials 767 767
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1850?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1850?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [13d07a3...7c7b0b3](https://codecov.io/gh/apache/incubator-inlong/pull/1850?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #1850: [INLONG-1849][Feature][InLong-Manager] Push Pulsar info for Sort
Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #1850:
URL: https://github.com/apache/incubator-inlong/pull/1850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a change in pull request #1850: [INLONG-1849][Feature][InLong-Manager] Push Pulsar info for Sort
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on a change in pull request #1850:
URL: https://github.com/apache/incubator-inlong/pull/1850#discussion_r757869065
##########
File path: inlong-manager/manager-web/src/main/resources/application-dev.properties
##########
@@ -54,15 +54,15 @@ cluster.tube.master=127.0.0.1:8000,127.0.0.1:8010
cluster.tube.clusterId=1
# Push configuration to the path on ZooKeeper
-cluster.zk.url=127.0.0.1:2181
+cluster.zk.url=9.135.102.89:2181
cluster.zk.root=inlong_hive
# Application name in Sort
sort.appName=inlong_app
# Pulsar admin URL
-pulsar.adminUrl=http://127.0.0.1:8080,127.0.0.2:8080,127.0.0.3:8080
+pulsar.adminUrl=http://9.135.102.89:8080
Review comment:
please remove the real ip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter commented on pull request #1850: [INLONG-1849][Feature][InLong-Manager] Push Pulsar info for Sort
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1850:
URL: https://github.com/apache/incubator-inlong/pull/1850#issuecomment-981052841
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1850?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1850](https://codecov.io/gh/apache/incubator-inlong/pull/1850?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a7a2256) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/13d07a30771311548ce9ce35e1aa8eb5878009ad?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (13d07a3) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-inlong/pull/1850?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1850 +/- ##
============================================
- Coverage 11.53% 11.52% -0.02%
+ Complexity 1049 1046 -3
============================================
Files 400 400
Lines 34789 34789
Branches 5504 5504
============================================
- Hits 4013 4008 -5
- Misses 30009 30016 +7
+ Partials 767 765 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/1850?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...inlong/tubemq/manager/service/TaskServiceImpl.java](https://codecov.io/gh/apache/incubator-inlong/pull/1850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtbWFuYWdlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW5sb25nL3R1YmVtcS9tYW5hZ2VyL3NlcnZpY2UvVGFza1NlcnZpY2VJbXBsLmphdmE=) | `3.65% <0.00%> (-4.88%)` | :arrow_down: |
| [...ong/tubemq/manager/service/ClusterServiceImpl.java](https://codecov.io/gh/apache/incubator-inlong/pull/1850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtbWFuYWdlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW5sb25nL3R1YmVtcS9tYW5hZ2VyL3NlcnZpY2UvQ2x1c3RlclNlcnZpY2VJbXBsLmphdmE=) | `50.00% <0.00%> (-2.95%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1850?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1850?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [13d07a3...a7a2256](https://codecov.io/gh/apache/incubator-inlong/pull/1850?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a change in pull request #1850: [INLONG-1849][Feature][InLong-Manager] Push Pulsar info for Sort
Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #1850:
URL: https://github.com/apache/incubator-inlong/pull/1850#discussion_r757869424
##########
File path: inlong-manager/manager-web/src/main/resources/application-dev.properties
##########
@@ -54,15 +54,15 @@ cluster.tube.master=127.0.0.1:8000,127.0.0.1:8010
cluster.tube.clusterId=1
# Push configuration to the path on ZooKeeper
-cluster.zk.url=127.0.0.1:2181
+cluster.zk.url=9.135.102.89:2181
cluster.zk.root=inlong_hive
# Application name in Sort
sort.appName=inlong_app
# Pulsar admin URL
-pulsar.adminUrl=http://127.0.0.1:8080,127.0.0.2:8080,127.0.0.3:8080
+pulsar.adminUrl=http://9.135.102.89:8080
Review comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org