[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #336: [ IOTDB-160]External sort

[GitBox <gi...@apache.org>]

jt2594838 commented on a change in pull request #336: [ IOTDB-160]External sort
URL: https://github.com/apache/incubator-iotdb/pull/336#discussion_r313690616
 
 

 ##########
 File path: server/src/main/java/org/apache/iotdb/db/query/externalsort/serialize/impl/SimpleTimeValuePairDeserializer.java
 ##########
 @@ -0,0 +1,84 @@
+/**
+ * Copyright © 2019 Apache IoTDB(incubating) (dev@iotdb.apache.org)
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.iotdb.db.query.externalsort.serialize.impl;
+
+import java.io.BufferedInputStream;
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.ObjectInputStream;
+import org.apache.iotdb.db.query.externalsort.serialize.TimeValuePairDeserializer;
+import org.apache.iotdb.db.utils.TimeValuePair;
+
+/**
+ * Deserializer TimeValuePair.
+ */
+public class SimpleTimeValuePairDeserializer implements TimeValuePairDeserializer {
+
+  private InputStream inputStream;
+  private ObjectInputStream objectInputStream;
+  private String tmpFilePath;
+
+  /**
+   * init with file path.
+   */
+  public SimpleTimeValuePairDeserializer(String tmpFilePath) throws IOException {
+    inputStream = new BufferedInputStream(new FileInputStream(tmpFilePath));
+    objectInputStream = new ObjectInputStream(inputStream);
+    this.tmpFilePath = tmpFilePath;
+  }
+
+  @Override
+  public Object getValueInTimestamp(long timestamp) throws IOException {
+    return null;
+  }
+
+  @Override
+  public boolean hasNext() throws IOException {
+    return inputStream.available() > 0;
+  }
+
+  @Override
+  public TimeValuePair next() throws IOException {
+    try {
+      return (TimeValuePair) objectInputStream.readUnshared();
+    } catch (ClassNotFoundException e) {
+      throw new IOException(e);
+    }
+  }
+
+  /**
+   * This method will delete.
 
 Review comment:
   This comment is missing something, do you mean "This method will delete the tmp file"?.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services