You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yida Wu (Code Review)" <ge...@cloudera.org> on 2026/10/07 05:22:12 UTC
[Impala-ASF-CR] IMPALA-15477: Fix wrong executing hosts in query profile
Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/25032
Change subject: IMPALA-15477: Fix wrong executing hosts in query profile
......................................................................
IMPALA-15477: Fix wrong executing hosts in query profile
In clusters configured with multiple custom executor groups under
the same set, the query profile could incorrectly report the wrong
backend hosts. Previously, Scheduler::ComputeBackendExecParams()
added the "Per Host Min Memory Reservation" and
"Per Host Number of Fragment Instances" info strings. A query is
scheduled once per candidate executor group and all those
schedules share one summary profile, so each group can overwrite
the previous one. The profile described whichever group was
scheduled last instead of the group the query was admitted to.
This patch adds the strings from the admission controller instead
after making the final decision. If the query is admitted, it uses
the hosts from the actually chosen group. If the query is rejected,
it uses the hosts from the group that triggered the rejection.
Testing:
Passed exhaustive tests.
Added two admission controller unit tests, and a check in
test_memory_rejection that a rejected query's profile has both strings.
Change-Id: Id48af82f9318f675deacb3b70dc52ae4ea519054
Assisted-by: Gemini 3.1 Pro
---
M be/src/scheduling/admission-controller-test.cc
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
M be/src/scheduling/scheduler.cc
M be/src/scheduling/scheduler.h
M tests/custom_cluster/test_admission_controller.py
6 files changed, 193 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/25032/3
--
To view, visit http://gerrit.cloudera.org:8080/25032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id48af82f9318f675deacb3b70dc52ae4ea519054
Gerrit-Change-Number: 25032
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-15477: Fix wrong executing hosts in query profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25032 )
Change subject: IMPALA-15477: Fix wrong executing hosts in query profile
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/24369/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/25032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id48af82f9318f675deacb3b70dc52ae4ea519054
Gerrit-Change-Number: 25032
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Oct 2026 05:45:31 +0000
Gerrit-HasComments: No