[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4103: Add validations to table config before updating a table config

[GitBox <gi...@apache.org>]

jackjlli commented on a change in pull request #4103: Add validations to table config before updating a table config
URL: https://github.com/apache/incubator-pinot/pull/4103#discussion_r274554170
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java
 ##########
 @@ -302,7 +302,7 @@ public SuccessResponse updateTableConfig(
 
       ensureMinReplicas(tableConfig);
       verifyTableConfigs(tableConfig);
-      _pinotHelixResourceManager.setExistingTableConfig(tableConfig, tableNameWithType, tableType);
+      _pinotHelixResourceManager.updateTableConfig(tableConfig, tableNameWithType, tableType);
 
 Review comment:
   We've already have a method called `verifyTableConfigs` in Line 304 and there's a new method `validateTableTenantConfig ` in `updateTableConfig`. Can they be merged together?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org