You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sadpandajoe (via GitHub)" <gi...@apache.org> on 2026/09/22 18:05:17 UTC
[PR] chore(cypress): remove dead dashboard drill-to-detail Cypress suite [superset]
sadpandajoe opened a new pull request, #44537:
URL: https://github.com/apache/superset/pull/44537
### SUMMARY
Removes the old Cypress dashboard drill-to-detail suite (`cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts`) and its dedicated helpers. The whole suite was wrapped in `describe.skip` (disabled due to Cypress-specific autoscroll/sticky-header flakiness) and contributed zero live coverage. It is fully superseded by the Playwright suite at `superset-frontend/playwright/tests/dashboard/dashboard-drill-to-detail.spec.ts`, which covers the same drill-to-detail flows with a more robust approach: canvas (echarts) drills scan a stable region of the canvas for the datum under the cursor instead of relying on hardcoded pixel coordinates, so they aren't tied to exact chart geometry.
Also removed:
- `shared_dashboard_functions.ts` and `dashboard/utils.ts` β helpers used only by the deleted suite.
- `support/directories.ts` β became fully orphaned once `dashboard/utils.ts` was removed (confirmed via repo-wide grep).
- Two dashboard URL constants (`SAMPLE_DASHBOARD_1`, `SUPPORTED_CHARTS_DASHBOARD`) only referenced by the deleted files.
One export from `dashboard/utils.ts` (`interceptGet`) was still used by the live `explore/chart.test.js` suite, so it was inlined into `explore/utils.ts` as `interceptDashboardGet` rather than deleted, and both call sites updated. `createSampleDashboards`/`dashboards.json` were kept as-is since `chart.test.js`'s "Cross-referenced dashboards" suite still exercises them.
Also fixes a stale example command in `docs/developer_docs/contributing/howtos.md` that referenced a Cypress spec file that no longer exists.
**Coverage note:** the Playwright suite intentionally excludes Bar, Area, World Map, and Radar chart drills, matching the original Cypress suite's own nested `describe.skip`s on those same four chart types β no regression, since those were already not running.
### TESTING INSTRUCTIONS
- `npm run type` and `pre-commit run` pass on the changed files.
- The Playwright replacement (`dashboard-drill-to-detail.spec.ts`) already exists on `master` and covers the migrated flows; run it via `npx playwright test tests/dashboard/dashboard-drill-to-detail.spec.ts`.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [x] Removes existing feature or API
π€ Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(cypress): remove dead dashboard drill-to-detail Cypress suite [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #44537:
URL: https://github.com/apache/superset/pull/44537#issuecomment-5785502054
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/44537?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 80.89%. Comparing base ([`0fe0662`](https://app.codecov.io/gh/apache/superset/commit/0fe0662b271b58b98cd8a719e848656ace5d23a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f7c86f1`](https://app.codecov.io/gh/apache/superset/commit/f7c86f19f417740a7dc70d5386623d20c9604245?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 9 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #44537 +/- ##
==========================================
+ Coverage 80.86% 80.89% +0.03%
==========================================
Files 2946 2948 +2
Lines 176943 177169 +226
Branches 40965 41061 +96
==========================================
+ Hits 143087 143328 +241
+ Misses 31155 31140 -15
Partials 2701 2701
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/44537/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/44537/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.31% <ΓΈ> (+0.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/44537?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(cypress): remove dead dashboard drill-to-detail Cypress suite [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #44537:
URL: https://github.com/apache/superset/pull/44537#issuecomment-5781513670
### <span aria-hidden="true">β
</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">π¨</span> Latest commit | 4d3331294840d683460530addce8e460836ad44b |
|<span aria-hidden="true">π</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6ab2c35e1b44de00084d8119 |
|<span aria-hidden="true">π</span> Deploy Preview | [https://deploy-preview-44537--superset-docs-preview.netlify.app](https://deploy-preview-44537--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">π±</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">π€</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcoxDoAgDADAv3SWBBSN-gOfUWiNg1pSiAkx_l22G-6FpHKlAitAB0HxjkfzzliM8iUPGznJEOYjCCqZWJNyzi0Tp1PqRq1PGPo4jOyC98TW2tnT7NwC3w8) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-44537--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(cypress): remove dead dashboard drill-to-detail Cypress suite [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44537:
URL: https://github.com/apache/superset/pull/44537#issuecomment-5787461730
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(cypress): remove dead dashboard drill-to-detail Cypress suite [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44537:
URL: https://github.com/apache/superset/pull/44537#issuecomment-5781488788
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(cypress): remove dead dashboard drill-to-detail Cypress suite [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #44537:
URL: https://github.com/apache/superset/pull/44537#discussion_r4087154928
##########
superset-frontend/cypress-base/cypress/e2e/explore/utils.ts:
##########
@@ -17,7 +17,9 @@
* under the License.
*/
-import { interceptGet as interceptDashboardGet } from '../dashboard/utils';
+export function interceptDashboardGet() {
+ cy.intercept('GET', '**/api/v1/dashboard/*').as('get');
+}
Review Comment:
**Suggestion:** The wildcard also matches `/api/v1/dashboard/?q=...`, which the save modal requests before saving, so `cy.wait('@get')` can consume the list request instead of the dashboard detail response.
**Assessment:** π `Major` Β· π `Occurrence: Often` Β· π·οΈ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=9c725e0a21b341dfbc31213c86a39f73&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=9c725e0a21b341dfbc31213c86a39f73&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent π€ </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/cypress-base/cypress/e2e/explore/utils.ts
**Line:** 20:22
**Comment:**
*Api Mismatch: The wildcard also matches `/api/v1/dashboard/?q=...`, which the save modal requests before saving, so `cy.wait('@get')` can consume the list request instead of the dashboard detail response.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44537&comment_hash=45b259c7be159ebd06d98c16c15046bed1fca4ebaf653a152a404ae11aba8455&reaction=like'>π</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44537&comment_hash=45b259c7be159ebd06d98c16c15046bed1fca4ebaf653a152a404ae11aba8455&reaction=dislike'>π</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(cypress): remove dead dashboard drill-to-detail Cypress suite [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44537:
URL: https://github.com/apache/superset/pull/44537#issuecomment-5784285702
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(cypress): remove dead dashboard drill-to-detail Cypress suite [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #44537:
URL: https://github.com/apache/superset/pull/44537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org