You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/10/21 05:07:17 UTC

[GitHub] codecov-io edited a comment on issue #3475: [AIRFLOW-2315] Improve S3Hook

codecov-io edited a comment on issue #3475: [AIRFLOW-2315] Improve S3Hook
URL: https://github.com/apache/incubator-airflow/pull/3475#issuecomment-413254466
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3475?src=pr&el=h1) Report
   > Merging [#3475](https://codecov.io/gh/apache/incubator-airflow/pull/3475?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-airflow/commit/b8be322d3badfeadfa8f08e0bf92a12a6cd26418?src=pr&el=desc) will **increase** coverage by `1.89%`.
   > The diff coverage is `93.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-airflow/pull/3475/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/incubator-airflow/pull/3475?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #3475      +/-   ##
   ==========================================
   + Coverage   75.79%   77.69%   +1.89%     
   ==========================================
     Files         199      204       +5     
     Lines       15946    15850      -96     
   ==========================================
   + Hits        12086    12314     +228     
   + Misses       3860     3536     -324
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-airflow/pull/3475?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/hooks/S3\_hook.py](https://codecov.io/gh/apache/incubator-airflow/pull/3475/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9TM19ob29rLnB5) | `96.77% <93.75%> (+2.44%)` | :arrow_up: |
   | [airflow/sensors/s3\_key\_sensor.py](https://codecov.io/gh/apache/incubator-airflow/pull/3475/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL3MzX2tleV9zZW5zb3IucHk=) | `31.03% <0%> (-68.97%)` | :arrow_down: |
   | [airflow/sensors/s3\_prefix\_sensor.py](https://codecov.io/gh/apache/incubator-airflow/pull/3475/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL3MzX3ByZWZpeF9zZW5zb3IucHk=) | `41.17% <0%> (-58.83%)` | :arrow_down: |
   | [airflow/utils/helpers.py](https://codecov.io/gh/apache/incubator-airflow/pull/3475/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `71.34% <0%> (-13.04%)` | :arrow_down: |
   | [airflow/hooks/mysql\_hook.py](https://codecov.io/gh/apache/incubator-airflow/pull/3475/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9teXNxbF9ob29rLnB5) | `78% <0%> (-12%)` | :arrow_down: |
   | [airflow/sensors/sql\_sensor.py](https://codecov.io/gh/apache/incubator-airflow/pull/3475/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL3NxbF9zZW5zb3IucHk=) | `90.47% <0%> (-9.53%)` | :arrow_down: |
   | [airflow/configuration.py](https://codecov.io/gh/apache/incubator-airflow/pull/3475/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `84.07% <0%> (-5.19%)` | :arrow_down: |
   | [airflow/utils/state.py](https://codecov.io/gh/apache/incubator-airflow/pull/3475/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zdGF0ZS5weQ==) | `93.33% <0%> (-3.34%)` | :arrow_down: |
   | [airflow/models.py](https://codecov.io/gh/apache/incubator-airflow/pull/3475/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMucHk=) | `88.74% <0%> (-2.97%)` | :arrow_down: |
   | [airflow/utils/email.py](https://codecov.io/gh/apache/incubator-airflow/pull/3475/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9lbWFpbC5weQ==) | `97.4% <0%> (-2.6%)` | :arrow_down: |
   | ... and [61 more](https://codecov.io/gh/apache/incubator-airflow/pull/3475/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3475?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3475?src=pr&el=footer). Last update [b8be322...5d4960d](https://codecov.io/gh/apache/incubator-airflow/pull/3475?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services