You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@accumulo.apache.org by ct...@apache.org on 2014/06/19 04:02:16 UTC
[28/28] git commit: ACCUMULO-378 Remove improper javadocs (no
descriptions with tags)
ACCUMULO-378 Remove improper javadocs (no descriptions with tags)
Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo
Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/bc7b5ff3
Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/bc7b5ff3
Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/bc7b5ff3
Branch: refs/heads/master
Commit: bc7b5ff3719ecda36c462dfbd75a9e0852d674fc
Parents: 77b39ae
Author: Christopher Tubbs <ct...@apache.org>
Authored: Wed Jun 18 21:58:55 2014 -0400
Committer: Christopher Tubbs <ct...@apache.org>
Committed: Wed Jun 18 21:58:55 2014 -0400
----------------------------------------------------------------------
.../accumulo/core/client/admin/ReplicationOperations.java | 8 --------
.../accumulo/core/client/replication/ReplicaSystem.java | 1 -
.../apache/accumulo/core/replication/ReplicationSchema.java | 6 ------
.../org/apache/accumulo/core/replication/StatusUtil.java | 1 -
.../accumulo/server/replication/ZooKeeperInitialization.java | 4 ----
.../accumulo/server/zookeeper/DistributedWorkQueue.java | 6 +-----
.../gc/replication/CloseWriteAheadLogReferences.java | 1 -
.../master/replication/DistributedWorkQueueWorkAssigner.java | 4 ----
.../org/apache/accumulo/master/replication/StatusMaker.java | 3 ---
.../accumulo/tserver/replication/AccumuloReplicaSystem.java | 2 --
.../org/apache/accumulo/tserver/session/SessionManager.java | 4 +---
11 files changed, 2 insertions(+), 38 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/accumulo/blob/bc7b5ff3/core/src/main/java/org/apache/accumulo/core/client/admin/ReplicationOperations.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/accumulo/core/client/admin/ReplicationOperations.java b/core/src/main/java/org/apache/accumulo/core/client/admin/ReplicationOperations.java
index 27ef538..4e24552 100644
--- a/core/src/main/java/org/apache/accumulo/core/client/admin/ReplicationOperations.java
+++ b/core/src/main/java/org/apache/accumulo/core/client/admin/ReplicationOperations.java
@@ -42,14 +42,12 @@ public interface ReplicationOperations {
* Defines a cluster with the given name and the given name system.
* @param name Unique name for the cluster
* @param replicaType {@link ReplicaSystem} class name to use to replicate the data
- * @throws PeerExistsException
*/
public void addPeer(String name, String replicaType) throws AccumuloException, AccumuloSecurityException, PeerExistsException;
/**
* Removes a cluster with the given name.
* @param name Name of the cluster to remove
- * @throws PeerNotFoundException
*/
public void removePeer(String name) throws AccumuloException, AccumuloSecurityException, PeerNotFoundException;
@@ -57,8 +55,6 @@ public interface ReplicationOperations {
* Waits for a table to be fully replicated, given the state of files pending replication for the provided table
* at the point in time which this method is invoked.
* @param tableName The table to wait for
- * @throws AccumuloException
- * @throws AccumuloSecurityException
*/
public void drain(String tableName) throws AccumuloException, AccumuloSecurityException, TableNotFoundException;
@@ -67,8 +63,6 @@ public interface ReplicationOperations {
* files to be fully replicated to all configured peers. This allows for the accurate calculation
* when a table, at a given point in time, has been fully replicated.
* @param tableName The table to wait for
- * @throws AccumuloException
- * @throws AccumuloSecurityException
*/
public void drain(String tableName, Set<String> files) throws AccumuloException, AccumuloSecurityException, TableNotFoundException;
@@ -79,8 +73,6 @@ public interface ReplicationOperations {
* <p>
* This also allows callers to get the {@link Set} of files for a table at some time, and later provide that
* {@link Set} to {@link #drain(String,Set)} to wait for all of those files to be replicated.
- * @param tableName
- * @throws TableNotFoundException
*/
public Set<String> referencedFiles(String tableName) throws AccumuloException, AccumuloSecurityException, TableNotFoundException;
}
http://git-wip-us.apache.org/repos/asf/accumulo/blob/bc7b5ff3/core/src/main/java/org/apache/accumulo/core/client/replication/ReplicaSystem.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/accumulo/core/client/replication/ReplicaSystem.java b/core/src/main/java/org/apache/accumulo/core/client/replication/ReplicaSystem.java
index cc51a11..900ae5a 100644
--- a/core/src/main/java/org/apache/accumulo/core/client/replication/ReplicaSystem.java
+++ b/core/src/main/java/org/apache/accumulo/core/client/replication/ReplicaSystem.java
@@ -41,7 +41,6 @@ public interface ReplicaSystem {
* <p>
* For example, we only need one implementation for Accumulo, but, for each peer,
* we have a ZK quorum and instance name
- * @param configuration
*/
public void configure(String configuration);
}
http://git-wip-us.apache.org/repos/asf/accumulo/blob/bc7b5ff3/core/src/main/java/org/apache/accumulo/core/replication/ReplicationSchema.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/accumulo/core/replication/ReplicationSchema.java b/core/src/main/java/org/apache/accumulo/core/replication/ReplicationSchema.java
index ab350e6..3804566 100644
--- a/core/src/main/java/org/apache/accumulo/core/replication/ReplicationSchema.java
+++ b/core/src/main/java/org/apache/accumulo/core/replication/ReplicationSchema.java
@@ -67,8 +67,6 @@ public class ReplicationSchema {
/**
* Limit the scanner to only pull replication work records
- *
- * @param scanner
*/
public static void limit(ScannerBase scanner) {
scanner.fetchColumnFamily(NAME);
@@ -136,8 +134,6 @@ public class ReplicationSchema {
/**
* Limit the scanner to only return Status records
- *
- * @param scanner
*/
public static void limit(ScannerBase scanner) {
scanner.fetchColumnFamily(NAME);
@@ -190,8 +186,6 @@ public class ReplicationSchema {
/**
* Limit the scanner to only return Order records
- *
- * @param scanner
*/
public static void limit(ScannerBase scanner) {
scanner.fetchColumnFamily(NAME);
http://git-wip-us.apache.org/repos/asf/accumulo/blob/bc7b5ff3/core/src/main/java/org/apache/accumulo/core/replication/StatusUtil.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/accumulo/core/replication/StatusUtil.java b/core/src/main/java/org/apache/accumulo/core/replication/StatusUtil.java
index 721f1e0..482fc62 100644
--- a/core/src/main/java/org/apache/accumulo/core/replication/StatusUtil.java
+++ b/core/src/main/java/org/apache/accumulo/core/replication/StatusUtil.java
@@ -167,7 +167,6 @@ public class StatusUtil {
/**
* @param v Value with serialized Status
* @return A Status created from the Value
- * @throws InvalidProtocolBufferException
*/
public static Status fromValue(Value v) throws InvalidProtocolBufferException {
return Status.parseFrom(v.get());
http://git-wip-us.apache.org/repos/asf/accumulo/blob/bc7b5ff3/server/base/src/main/java/org/apache/accumulo/server/replication/ZooKeeperInitialization.java
----------------------------------------------------------------------
diff --git a/server/base/src/main/java/org/apache/accumulo/server/replication/ZooKeeperInitialization.java b/server/base/src/main/java/org/apache/accumulo/server/replication/ZooKeeperInitialization.java
index 9e0a5a6..a97853d 100644
--- a/server/base/src/main/java/org/apache/accumulo/server/replication/ZooKeeperInitialization.java
+++ b/server/base/src/main/java/org/apache/accumulo/server/replication/ZooKeeperInitialization.java
@@ -29,10 +29,6 @@ import org.apache.zookeeper.KeeperException;
public class ZooKeeperInitialization {
/**
* Ensure that the full path to ZooKeeper nodes that will be used exist
- * @param zooReaderWriter
- * @param zRoot
- * @throws KeeperException
- * @throws InterruptedException
*/
public static void ensureZooKeeperInitialized(final ZooReaderWriter zooReaderWriter, final String zRoot) throws KeeperException, InterruptedException {
if (!zooReaderWriter.exists(zRoot + ReplicationConstants.ZOO_TSERVERS, null)) {
http://git-wip-us.apache.org/repos/asf/accumulo/blob/bc7b5ff3/server/base/src/main/java/org/apache/accumulo/server/zookeeper/DistributedWorkQueue.java
----------------------------------------------------------------------
diff --git a/server/base/src/main/java/org/apache/accumulo/server/zookeeper/DistributedWorkQueue.java b/server/base/src/main/java/org/apache/accumulo/server/zookeeper/DistributedWorkQueue.java
index 6f4ea95..0f1a005 100644
--- a/server/base/src/main/java/org/apache/accumulo/server/zookeeper/DistributedWorkQueue.java
+++ b/server/base/src/main/java/org/apache/accumulo/server/zookeeper/DistributedWorkQueue.java
@@ -165,7 +165,7 @@ public class DistributedWorkQueue {
public void startProcessing(final Processor processor, ThreadPoolExecutor executorService) throws KeeperException, InterruptedException {
- threadPool = (ThreadPoolExecutor) executorService;
+ threadPool = executorService;
zoo.mkdirs(path);
zoo.mkdirs(path + "/" + LOCKS_NODE);
@@ -217,10 +217,6 @@ public class DistributedWorkQueue {
/**
* Adds work to the queue, automatically converting the String to bytes using {@link StandardCharsets#UTF_8}
- * @param workId
- * @param data
- * @throws KeeperException
- * @throws InterruptedException
*/
public void addWork(String workId, String data) throws KeeperException, InterruptedException {
addWork(workId, data.getBytes(StandardCharsets.UTF_8));
http://git-wip-us.apache.org/repos/asf/accumulo/blob/bc7b5ff3/server/gc/src/main/java/org/apache/accumulo/gc/replication/CloseWriteAheadLogReferences.java
----------------------------------------------------------------------
diff --git a/server/gc/src/main/java/org/apache/accumulo/gc/replication/CloseWriteAheadLogReferences.java b/server/gc/src/main/java/org/apache/accumulo/gc/replication/CloseWriteAheadLogReferences.java
index d649c3e..b88dcdc 100644
--- a/server/gc/src/main/java/org/apache/accumulo/gc/replication/CloseWriteAheadLogReferences.java
+++ b/server/gc/src/main/java/org/apache/accumulo/gc/replication/CloseWriteAheadLogReferences.java
@@ -245,7 +245,6 @@ public class CloseWriteAheadLogReferences implements Runnable {
* BatchWriter
* @param k
* Key to create close mutation from
- * @throws MutationsRejectedException
*/
protected void closeWal(BatchWriter bw, Key k) throws MutationsRejectedException {
log.debug("Closing unreferenced WAL ({}) in metadata table", k.toStringNoTruncate());
http://git-wip-us.apache.org/repos/asf/accumulo/blob/bc7b5ff3/server/master/src/main/java/org/apache/accumulo/master/replication/DistributedWorkQueueWorkAssigner.java
----------------------------------------------------------------------
diff --git a/server/master/src/main/java/org/apache/accumulo/master/replication/DistributedWorkQueueWorkAssigner.java b/server/master/src/main/java/org/apache/accumulo/master/replication/DistributedWorkQueueWorkAssigner.java
index 234b153..1eb6cc4 100644
--- a/server/master/src/main/java/org/apache/accumulo/master/replication/DistributedWorkQueueWorkAssigner.java
+++ b/server/master/src/main/java/org/apache/accumulo/master/replication/DistributedWorkQueueWorkAssigner.java
@@ -110,8 +110,6 @@ public abstract class DistributedWorkQueueWorkAssigner implements WorkAssigner {
/**
* Initialize the DistributedWorkQueue using the proper ZK location
- *
- * @param conf
*/
protected void initializeWorkQueue(AccumuloConfiguration conf) {
workQueue = new DistributedWorkQueue(ZooUtil.getRoot(conn.getInstance()) + ReplicationConstants.ZOO_WORK_QUEUE, conf);
@@ -266,8 +264,6 @@ public abstract class DistributedWorkQueueWorkAssigner implements WorkAssigner {
/**
* Remove the given work from the internal state
- * @param target
- * @param queueKey
*/
protected abstract void removeQueuedWork(ReplicationTarget target, String queueKey);
http://git-wip-us.apache.org/repos/asf/accumulo/blob/bc7b5ff3/server/master/src/main/java/org/apache/accumulo/master/replication/StatusMaker.java
----------------------------------------------------------------------
diff --git a/server/master/src/main/java/org/apache/accumulo/master/replication/StatusMaker.java b/server/master/src/main/java/org/apache/accumulo/master/replication/StatusMaker.java
index c054de2..68dd005 100644
--- a/server/master/src/main/java/org/apache/accumulo/master/replication/StatusMaker.java
+++ b/server/master/src/main/java/org/apache/accumulo/master/replication/StatusMaker.java
@@ -155,9 +155,6 @@ public class StatusMaker {
/**
* Create a status record in the replication table
- * @param file
- * @param tableId
- * @param v
*/
protected boolean addStatusRecord(Text file, Text tableId, Value v) {
try {
http://git-wip-us.apache.org/repos/asf/accumulo/blob/bc7b5ff3/server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
----------------------------------------------------------------------
diff --git a/server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java b/server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
index b121641..099718b 100644
--- a/server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
+++ b/server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
@@ -579,8 +579,6 @@ public class AccumuloReplicaSystem implements ReplicaSystem {
/**
* Wrapper around {@link LogFileValue#write(java.io.DataOutput)} which does not serialize {@link Mutation}s that do not need to be replicate to the given
* {@link ReplicationTarget}
- *
- * @throws IOException
*/
protected long writeValueAvoidingReplicationCycles(DataOutputStream out, LogFileValue value, ReplicationTarget target) throws IOException {
int mutationsToSend = 0;
http://git-wip-us.apache.org/repos/asf/accumulo/blob/bc7b5ff3/server/tserver/src/main/java/org/apache/accumulo/tserver/session/SessionManager.java
----------------------------------------------------------------------
diff --git a/server/tserver/src/main/java/org/apache/accumulo/tserver/session/SessionManager.java b/server/tserver/src/main/java/org/apache/accumulo/tserver/session/SessionManager.java
index ab8bbe3..571d85c 100644
--- a/server/tserver/src/main/java/org/apache/accumulo/tserver/session/SessionManager.java
+++ b/server/tserver/src/main/java/org/apache/accumulo/tserver/session/SessionManager.java
@@ -22,8 +22,8 @@ import java.util.HashMap;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
-import java.util.TimerTask;
import java.util.Map.Entry;
+import java.util.TimerTask;
import org.apache.accumulo.core.client.impl.Translator;
import org.apache.accumulo.core.client.impl.Translators;
@@ -82,8 +82,6 @@ public class SessionManager {
/**
* while a session is reserved, it cannot be canceled or removed
- *
- * @param sessionId
*/
public synchronized Session reserveSession(long sessionId) {