You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/07/17 03:44:08 UTC
[GitHub] [tvm] wrongtest-intellif opened a new pull request, #12118: [TVMScript] Fix T.Ptr[T.void] for packed api roundtrip
wrongtest-intellif opened a new pull request, #12118:
URL: https://github.com/apache/tvm/pull/12118
Add missing type annotation `T.void` of prim type `void`, since either `""` or `None` is not valid type generic.
This is used by PrimFunc with packed api:
```python
@T.prim_func
def default_function(args: T.handle, arg_type_ids: T.Ptr[T.int32], num_args: T.int32,
out_ret_value: T.Ptr[T.void], out_ret_tcode: T.Ptr[T.int32], resource_handle: T.handle) -> T.int32:
# ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] wrongtest-intellif commented on pull request #12118: [TVMScript] Fix T.Ptr[T.void] for packed api roundtrip
Posted by GitBox <gi...@apache.org>.
wrongtest-intellif commented on PR #12118:
URL: https://github.com/apache/tvm/pull/12118#issuecomment-1186432147
cc @junrushao1994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cyx-6 commented on a diff in pull request #12118: [TVMScript] Fix T.Ptr[T.void] for packed api roundtrip
Posted by GitBox <gi...@apache.org>.
cyx-6 commented on code in PR #12118:
URL: https://github.com/apache/tvm/pull/12118#discussion_r927278889
##########
tests/python/unittest/test_tvmscript_roundtrip.py:
##########
@@ -3297,6 +3297,14 @@ def func():
return func
+def void_ptr():
Review Comment:
I will update it in new parser:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a diff in pull request #12118: [TVMScript] Fix T.Ptr[T.void] for packed api roundtrip
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on code in PR #12118:
URL: https://github.com/apache/tvm/pull/12118#discussion_r922978557
##########
tests/python/unittest/test_tvmscript_roundtrip.py:
##########
@@ -3297,6 +3297,14 @@ def func():
return func
+def void_ptr():
Review Comment:
CC: @cyx-6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] wrongtest-intellif merged pull request #12118: [TVMScript] Fix T.Ptr[T.void] for packed api roundtrip
Posted by GitBox <gi...@apache.org>.
wrongtest-intellif merged PR #12118:
URL: https://github.com/apache/tvm/pull/12118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org