You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/05/24 10:14:35 UTC
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2442:
'-Long.MAX_VALUE' in assertSetWorkerIdFailureWhenTooMuch() method is not
reasonable
tristaZero commented on issue #2442: '-Long.MAX_VALUE' in assertSetWorkerIdFailureWhenTooMuch() method is not reasonable
URL: https://github.com/apache/incubator-shardingsphere/issues/2442#issuecomment-495558806
Hi, @wgy8283335 thanks for your issue.
Actually, the bounds of worker.id is `worker.id >= 0L && worker.id < WORKER_ID_MAX_VALUE`.
In this test case, although whether `Long.MIN_VALUE` or `-Long.MAX_VALUE` can make this case pass, but `Long.MIN_VALUE` is more accurate.
Thanks for your suggestion, if it is available, can you send a pull request to fix this issue?
Waiting for your reply.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services