You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/12/03 16:42:15 UTC

[GitHub] [dubbo-go] A-Wanderer opened a new pull request #1640: Add: user define config

A-Wanderer opened a new pull request #1640:
URL: https://github.com/apache/dubbo-go/pull/1640


   <!--  Thanks for sending a pull request!
   Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
   -->
   
   **What this PR does**:
   
   **Which issue(s) this PR fixes**:
   <!--
   *Automatically closes linked issue when PR is merged.
   Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
   _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
   -->
   Fixes #
   
   **Special notes for your reviewer**:
   
   **Does this PR introduce a user-facing change?**:
   <!--
   If no, just write "NONE" in the release-note block below.
   If yes, a release note is required:
   Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
   -->
   ```release-note
   add user define config so that user can define somthing in config file
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] LaurenceLiZhixin merged pull request #1640: Add: user define config

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin merged pull request #1640:
URL: https://github.com/apache/dubbo-go/pull/1640


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter commented on pull request #1640: Add: user define config

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1640:
URL: https://github.com/apache/dubbo-go/pull/1640#issuecomment-986750458


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1640?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1640](https://codecov.io/gh/apache/dubbo-go/pull/1640?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a359967) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/a2c073182e59bf7e16455c6ab4bf0229a71c9741?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a2c0731) will **increase** coverage by `0.30%`.
   > The diff coverage is `65.21%`.
   
   > :exclamation: Current head a359967 differs from pull request most recent head a1e9bff. Consider uploading reports for the commit a1e9bff to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1640/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1640?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1640      +/-   ##
   ==========================================
   + Coverage   41.05%   41.35%   +0.30%     
   ==========================================
     Files         253      254       +1     
     Lines       14501    14544      +43     
   ==========================================
   + Hits         5953     6015      +62     
   + Misses       7859     7833      -26     
   - Partials      689      696       +7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1640?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [cluster/cluster/base/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2Jhc2UvY2x1c3Rlcl9pbnZva2VyLmdv) | `37.36% <0.00%> (+13.18%)` | :arrow_up: |
   | [config\_center/parser/configuration\_parser.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci9wYXJzZXIvY29uZmlndXJhdGlvbl9wYXJzZXIuZ28=) | `66.91% <0.00%> (ø)` | |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `0.00% <ø> (ø)` | |
   | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [config/root\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Jvb3RfY29uZmlnLmdv) | `39.76% <66.66%> (+2.19%)` | :arrow_up: |
   | [config/user\_define\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3VzZXJfZGVmaW5lX2NvbmZpZy5nbw==) | `81.25% <81.25%> (ø)` | |
   | [cluster/cluster/failback/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2ZhaWxiYWNrL2NsdXN0ZXJfaW52b2tlci5nbw==) | `75.82% <100.00%> (ø)` | |
   | [cluster/cluster/failsafe/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2ZhaWxzYWZlL2NsdXN0ZXJfaW52b2tlci5nbw==) | `81.81% <100.00%> (ø)` | |
   | [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `50.48% <100.00%> (+0.48%)` | :arrow_up: |
   | ... and [6 more](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1640?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1640?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a2c0731...a1e9bff](https://codecov.io/gh/apache/dubbo-go/pull/1640?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] cjphaha commented on pull request #1640: Add: user define config

Posted by GitBox <gi...@apache.org>.
cjphaha commented on pull request #1640:
URL: https://github.com/apache/dubbo-go/pull/1640#issuecomment-986838503


   👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1640: Add: user define config

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #1640:
URL: https://github.com/apache/dubbo-go/pull/1640#issuecomment-986912487


   事实证明是这个问题，我认为这个pr可以merge了。相关rootConfig问题麻烦记录个issue。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1640: Add: user define config

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1640:
URL: https://github.com/apache/dubbo-go/pull/1640#discussion_r763103676



##########
File path: config/testdata/config/custom/custom.yaml
##########
@@ -0,0 +1,13 @@
+dubbo:
+  registries:
+    nacos:
+      timeout: 5s
+      group: dev
+      address: nacos://127.0.0.1:8848
+    zk:
+      protocol: zookeeper
+      group: test
+      address: 127.0.0.1:2181
+  custom:
+      config-map:

Review comment:
       这里缩进是不是有问题？ @A-Wanderer 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1640: Add: user define config

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1640:
URL: https://github.com/apache/dubbo-go/pull/1640#issuecomment-986750458


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1640?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1640](https://codecov.io/gh/apache/dubbo-go/pull/1640?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (83a6770) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/a2c073182e59bf7e16455c6ab4bf0229a71c9741?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a2c0731) will **increase** coverage by `0.25%`.
   > The diff coverage is `77.14%`.
   
   > :exclamation: Current head 83a6770 differs from pull request most recent head 1eb4eb9. Consider uploading reports for the commit 1eb4eb9 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1640/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1640?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1640      +/-   ##
   ==========================================
   + Coverage   41.05%   41.30%   +0.25%     
   ==========================================
     Files         253      254       +1     
     Lines       14501    14544      +43     
   ==========================================
   + Hits         5953     6008      +55     
   + Misses       7859     7843      -16     
   - Partials      689      693       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1640?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/root\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Jvb3RfY29uZmlnLmdv) | `39.76% <66.66%> (+2.19%)` | :arrow_up: |
   | [config/custom\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2N1c3RvbV9jb25maWcuZ28=) | `79.31% <79.31%> (ø)` | |
   | [metrics/prometheus/reporter.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0cmljcy9wcm9tZXRoZXVzL3JlcG9ydGVyLmdv) | `26.85% <0.00%> (-1.72%)` | :arrow_down: |
   | [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `0.00% <0.00%> (ø)` | |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `50.48% <0.00%> (+0.48%)` | :arrow_up: |
   | [metadata/report/nacos/report.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvcmVwb3J0L25hY29zL3JlcG9ydC5nbw==) | `40.00% <0.00%> (+1.76%)` | :arrow_up: |
   | [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `34.37% <0.00%> (+3.14%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1640?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1640?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a2c0731...1eb4eb9](https://codecov.io/gh/apache/dubbo-go/pull/1640?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1640: Add: user define config

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1640:
URL: https://github.com/apache/dubbo-go/pull/1640#discussion_r763134006



##########
File path: config/custom_config_test.go
##########
@@ -54,17 +52,14 @@ func TestCustomInit(t *testing.T) {
 
 	t.Run("config builder", func(t *testing.T) {
 		CustomConfigBuilder := NewCustomConfigBuilder()
-		CustomConfigBuilder.SetVersion("v3.0")
 		CustomConfigBuilder.SetDefineConfig("test-build", true)
 		CustomConfig := CustomConfigBuilder.Build()
 		assert.NotNil(t, CustomConfig)
-		assert.Equal(t, CustomConfig.Version, "v3.0")
 		assert.Equal(t, CustomConfig.GetDefineValue("test-build", false), true)
 		assert.Equal(t, CustomConfig.GetDefineValue("test-no-build", false), false)
-		rt := NewRootConfigBuilder().Build()
-		assert.Equal(t, rt.Custom.Version, "")
-		rt = NewRootConfigBuilder().SetCustom(CustomConfig).Build()
-		rt.Init()
-		assert.Equal(t, rt.Custom.Version, "v3.0")
+		rt := NewRootConfigBuilder().SetCustom(CustomConfig).Build()
+		SetRootConfig(*rt)

Review comment:
       看上去问题出在这里，我修下，这貌似是个 rootConfig 的小问题。




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1640: Add: user define config

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1640:
URL: https://github.com/apache/dubbo-go/pull/1640#issuecomment-986750458


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1640?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1640](https://codecov.io/gh/apache/dubbo-go/pull/1640?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1eb4eb9) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/a2c073182e59bf7e16455c6ab4bf0229a71c9741?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a2c0731) will **increase** coverage by `0.29%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1640/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1640?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1640      +/-   ##
   ==========================================
   + Coverage   41.05%   41.35%   +0.29%     
   ==========================================
     Files         253      254       +1     
     Lines       14501    14541      +40     
   ==========================================
   + Hits         5953     6013      +60     
   + Misses       7859     7835      -24     
   - Partials      689      693       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1640?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/root\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Jvb3RfY29uZmlnLmdv) | `40.93% <66.66%> (+3.35%)` | :arrow_up: |
   | [config/custom\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2N1c3RvbV9jb25maWcuZ28=) | `76.92% <76.92%> (ø)` | |
   | [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `0.00% <0.00%> (ø)` | |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `50.48% <0.00%> (+0.48%)` | :arrow_up: |
   | [metadata/report/nacos/report.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvcmVwb3J0L25hY29zL3JlcG9ydC5nbw==) | `40.00% <0.00%> (+1.76%)` | :arrow_up: |
   | [cluster/cluster/failback/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2ZhaWxiYWNrL2NsdXN0ZXJfaW52b2tlci5nbw==) | `78.02% <0.00%> (+2.19%)` | :arrow_up: |
   | [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `34.37% <0.00%> (+3.14%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/dubbo-go/pull/1640/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1640?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1640?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a2c0731...1eb4eb9](https://codecov.io/gh/apache/dubbo-go/pull/1640?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org