[GitHub] [skywalking] kezhenxu94 commented on issue #2846: Add config to control tracing sql parameters in MySQL agent

[GitBox <gi...@apache.org>]

kezhenxu94 commented on issue #2846: Add config to control tracing sql parameters in MySQL agent
URL: https://github.com/apache/skywalking/pull/2846#issuecomment-500461320
 
 
   > For `InputStream[length]`, I am not sure whether it is worth to do.
   
   The reason why I'd like to do this is to make it a placeholder, as you said:
   
   > If one parameter is ignored somehow, parameter list would match, unless you keep a ? or InputStream or something to be a placeholder.
   
   keeping a `?` as placeholder is fine for me.
   
   > If the parameter includes `,`, what happens?
   
   quoting the parameter with `"` seems to be not perfect either, I'll think about this

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services