You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/18 16:51:08 UTC
[GitHub] [camel] ludovic-boutros opened a new pull request, #8728: [CAMEL-18728]: Fix elasticsearch-rest component name and package in order to prevent component name clash for DSLs.
ludovic-boutros opened a new pull request, #8728:
URL: https://github.com/apache/camel/pull/8728
Fix elasticsearch-rest component name and package in order to prevent component name clash.
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8728: [CAMEL-18728]: Fix elasticsearch-rest component name and package in order to prevent component name clash for DSLs.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8728:
URL: https://github.com/apache/camel/pull/8728#issuecomment-1320343365
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 2 | 2 | 2 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #8728: [CAMEL-18728]: Fix elasticsearch-rest component name and package in order to prevent component name clash for DSLs.
Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #8728:
URL: https://github.com/apache/camel/pull/8728#issuecomment-1320348161
I rather prefer that we add an exception in the maven plugin directly as it has already been done [here](https://github.com/apache/camel/blob/main/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointDslMojo.java#L1000-L1005)
Simply adds:
```
case "org.apache.camel.component.elasticsearch.ElasticsearchComponent":
return "ElasticsearchRest";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8728: [CAMEL-18728]: Fix elasticsearch-rest component name to prevent component name clash
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8728:
URL: https://github.com/apache/camel/pull/8728#issuecomment-1320926524
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 4 | 4 | 0 | 4 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8728: [CAMEL-18728]: Fix elasticsearch-rest component name and package in order to prevent component name clash for DSLs.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8728:
URL: https://github.com/apache/camel/pull/8728#issuecomment-1320276834
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8728: [CAMEL-18728]: Fix elasticsearch-rest component name and package in order to prevent component name clash for DSLs.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8728:
URL: https://github.com/apache/camel/pull/8728#issuecomment-1320879242
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 3 | 3 | 0 | 3 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo merged pull request #8728: [CAMEL-18728]: Fix elasticsearch-rest component name to prevent component name clash
Posted by GitBox <gi...@apache.org>.
essobedo merged PR #8728:
URL: https://github.com/apache/camel/pull/8728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ludovic-boutros commented on pull request #8728: [CAMEL-18728]: Fix elasticsearch-rest component name and package in order to prevent component name clash for DSLs.
Posted by GitBox <gi...@apache.org>.
ludovic-boutros commented on PR #8728:
URL: https://github.com/apache/camel/pull/8728#issuecomment-1320420905
I will follow the way you all suggested.
I did not know it. It's far more simple !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #8728: [CAMEL-18728]: Fix elasticsearch-rest component name to prevent component name clash
Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #8728:
URL: https://github.com/apache/camel/pull/8728#issuecomment-1320887961
Could you please also remove "in order" from your commit message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ludovic-boutros commented on pull request #8728: [CAMEL-18728]: Fix elasticsearch-rest component name to prevent component name clash
Posted by GitBox <gi...@apache.org>.
ludovic-boutros commented on PR #8728:
URL: https://github.com/apache/camel/pull/8728#issuecomment-1320916036
@essobedo it should be good now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ludovic-boutros commented on pull request #8728: [CAMEL-18728]: Fix elasticsearch-rest component name and package in order to prevent component name clash for DSLs.
Posted by GitBox <gi...@apache.org>.
ludovic-boutros commented on PR #8728:
URL: https://github.com/apache/camel/pull/8728#issuecomment-1320867598
It should be ok now. So easy when you understand the build process a bit more 👍 .
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org