You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "ZEALi (via GitHub)" <gi...@apache.org> on 2023/03/17 06:07:27 UTC
[GitHub] [skywalking-python] ZEALi opened a new pull request, #296: Don't install loguru when not active
ZEALi opened a new pull request, #296:
URL: https://github.com/apache/skywalking-python/pull/296
As a log reporter, it should not be activated when user don't want (agent.archive_log will fail).
maybe sw_loguru should be treated as sw_logging which is installed before other normal plugins in agent.start(),
or re-factor sw_loguru & sw_logging into a "log reporter" plugins instead of default "trace reporter" plugins?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #296: Don't install loguru when not active
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on PR #296:
URL: https://github.com/apache/skywalking-python/pull/296#issuecomment-1502650505
Any updates? @ZEALi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #296: Don't install loguru when not active
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on PR #296:
URL: https://github.com/apache/skywalking-python/pull/296#issuecomment-1474205193
Please remember to add a changelog for this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #296: Don't install loguru when not active
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on PR #296:
URL: https://github.com/apache/skywalking-python/pull/296#issuecomment-1474204368
Please fix lint.
Regarding your question, I think I would prefer the second design as it is more clear and support future extensions. Would you like to proceed on the refactor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #296: Don't install loguru when not active
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on PR #296:
URL: https://github.com/apache/skywalking-python/pull/296#issuecomment-1519191942
Closing this in favor of a newer PR including this change https://github.com/apache/skywalking-python/pull/302/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] ZEALi commented on pull request #296: Don't install loguru when not active
Posted by "ZEALi (via GitHub)" <gi...@apache.org>.
ZEALi commented on PR #296:
URL: https://github.com/apache/skywalking-python/pull/296#issuecomment-1475657514
>
Sure. I'll work on the sepreated hook for “log reporter” plugins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy closed pull request #296: Don't install loguru when not active
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy closed pull request #296: Don't install loguru when not active
URL: https://github.com/apache/skywalking-python/pull/296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org