[jira] [Work logged] (ARTEMIS-2931) Potential null pointer access at several places

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-2931?focusedWorklogId=507269&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-507269 ]

ASF GitHub Bot logged work on ARTEMIS-2931:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Nov/20 18:45
            Start Date: 03/Nov/20 18:45
    Worklog Time Spent: 10m 
      Work Description: jbertram commented on a change in pull request #3295:
URL: https://github.com/apache/activemq-artemis/pull/3295#discussion_r516881849



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
##########
@@ -565,11 +565,12 @@ public boolean checkPageFileExists(final int pageNumber) {
       SequentialFileFactory factory = null;
       try {
          factory = checkFileFactory();
+         SequentialFile file = factory.createSequentialFile(fileName);
+         return file.exists();
       } catch (Exception ignored) {
+         assert false : "PagingStoreFactory::newFileFactory never-throws assumption failed.";

Review comment:
       I'm not sure about this `assert` here. First, it references "newFileFactory" which I think is incorrect. Second, I think just returning `false` would be sufficient.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 507269)
    Time Spent: 20m  (was: 10m)

>  Potential null pointer access at several places
> ------------------------------------------------
>
>                 Key: ARTEMIS-2931
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2931
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>            Reporter: Petr Kuzel
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Open the artemis-server project in Eclipse. Static analysis reports numerous Potential null pointer access. Looking at an example, the static analyzer is correct.
> ReplicationEndpoint:
> {code:java}
>    public void setChannel(final Channel channel) {
>       this.channel = channel;
>       if (channel == null) {
>          supportResponseBatching = false;
>       } else {
>          try {
>             final CoreRemotingConnection connection = channel.getConnection();
>             if (connection != null) {
>                this.supportResponseBatching = connection.getTransportConnection() instanceof NettyConnection;
>             } else {
>                this.supportResponseBatching = false;
>             }
>          } catch (Throwable t) {
>             logger.warn("Error while checking the channel connection", t);
>             this.supportResponseBatching = false;
>          }
>       }      if (this.channel != null && outgoingInterceptors != null) {
>          if (channel.getConnection() instanceof RemotingConnectionImpl)  { // NPE risk
> {code}
> line 392 the channel can be null.
> line 409 for unknown reason assumes the channel is never null.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)