[GitHub] [arrow] patrickpai commented on a change in pull request #7789: PARQUET-1878: [C++] lz4 codec is not compatible with Hadoop Lz4Codec

[GitBox <gi...@apache.org>]

patrickpai commented on a change in pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#discussion_r464602366



##########
File path: cpp/src/arrow/util/compression.cc
##########
@@ -131,7 +131,7 @@ Result<std::unique_ptr<Codec>> Codec::Create(Compression::type codec_type,
       if (compression_level_set) {
         return Status::Invalid("LZ4 doesn't support setting a compression level.");
       }
-      codec = internal::MakeLz4RawCodec();
+      codec = internal::MakeLz4HadoopRawCodec();

Review comment:
       Does this have to do with the earlier discussion with @pitrou? 
   
   And just to clarify, by adding `Compression::LZ4_HADOOP` the goal is to distinguish the two codec implementations at the enum level? So we'd need to determine whether an incoming parquet file was compressed using Lz4 or Hadoop Lz4 by checking for file version in the parquet file metadata?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org