[GitHub] [airflow] potiuk commented on a diff in pull request #21942: Improve ElasticsearchTaskHandler

[GitBox <gi...@apache.org>]

potiuk commented on code in PR #21942:
URL: https://github.com/apache/airflow/pull/21942#discussion_r848664624


##########
airflow/utils/log/json_formatter.py:
##########
@@ -21,12 +21,18 @@
 import json
 import logging
 
+import pendulum

Review Comment:
   This is part of the airflow core.  This change changes elasticsearch provider so there are two problems: 
   
   1) What happens if the new provider is installed with old airflow? Do we have some dependency here on those modifications? I guess yes because otherwise you would not not change it. Can you please make it standalone in the way that it will not require changes in airlfow core?
   
   2) Secondly (related)- what's the impact of this change on the rest of Airlfow? How formatTime addition will impact any other place  that uses JSONFormatter? Did you try to assess the impact?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org