You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kathey Marsden (JIRA)" <ji...@apache.org> on 2011/02/02 19:29:34 UTC
[jira] Created: (DERBY-4997) SysinfoTest version output filtering
is fragile with new java versions
SysinfoTest version output filtering is fragile with new java versions
-----------------------------------------------------------------------
Key: DERBY-4997
URL: https://issues.apache.org/jira/browse/DERBY-4997
Project: Derby
Issue Type: Bug
Components: Test
Reporter: Kathey Marsden
Priority: Minor
Some newer java version output may have lines lines that are not filtered out by the existing SysinfoTest.
Myrna suggests checking for and filtering out the exact properties we expect to see to make a better test and make it less fragile.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4997) SysinfoTest version output
filtering is fragile with new java versions
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990385#comment-12990385 ]
Kathey Marsden commented on DERBY-4997:
---------------------------------------
I have been looking at this test derbynet.SysinfoTest and it seems to me its focus is to make sure the network server properties derby.drda.* print.
It does this by replacing everything else with empty strings in the sed() method. I am thinking that we should just have the test check for the things it is looking for and not fail for additional lines as it often does as new things are added or if jvm's have multiline version output.
One thing to note is that while the output checks for this test focus on network server, this is the only test that we actually have for Sysinfo,
So it might be nice to expand it at some point to check the other things that sysinfo outputs. As another aside I am seeing permission errors in the sysinfo output for java.home, user.name and user.home. I thought this was addressed at one point, but will file an issue if needed.
> SysinfoTest version output filtering is fragile with new java versions
> -----------------------------------------------------------------------
>
> Key: DERBY-4997
> URL: https://issues.apache.org/jira/browse/DERBY-4997
> Project: Derby
> Issue Type: Bug
> Components: Test
> Reporter: Kathey Marsden
> Priority: Minor
> Attachments: derby-4997_notforcommit.txt
>
>
> Some newer java version output may have lines lines that are not filtered out by the existing SysinfoTest.
> Myrna suggests checking for and filtering out the exact properties we expect to see to make a better test and make it less fragile.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-4997) SysinfoTest version output filtering
is fragile with new java versions
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-4997:
----------------------------------
Issue & fix info: [Newcomer, Patch Available] (was: [Newcomer])
> SysinfoTest version output filtering is fragile with new java versions
> -----------------------------------------------------------------------
>
> Key: DERBY-4997
> URL: https://issues.apache.org/jira/browse/DERBY-4997
> Project: Derby
> Issue Type: Bug
> Components: Test
> Reporter: Kathey Marsden
> Priority: Minor
> Attachments: derby-4997_diff.txt, derby-4997_notforcommit.txt
>
>
> Some newer java version output may have lines lines that are not filtered out by the existing SysinfoTest.
> Myrna suggests checking for and filtering out the exact properties we expect to see to make a better test and make it less fragile.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-4997) SysinfoTest version output filtering
is fragile with new java versions
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-4997:
----------------------------------
Attachment: derby-4997_notforcommit.txt
This was my first shot at fixing this issue for an IBM jvm, but I want to make it more generic as Myrna suggested. Attaching mostly to try out attach in New Jira.
> SysinfoTest version output filtering is fragile with new java versions
> -----------------------------------------------------------------------
>
> Key: DERBY-4997
> URL: https://issues.apache.org/jira/browse/DERBY-4997
> Project: Derby
> Issue Type: Bug
> Components: Test
> Reporter: Kathey Marsden
> Priority: Minor
> Attachments: derby-4997_notforcommit.txt
>
>
> Some newer java version output may have lines lines that are not filtered out by the existing SysinfoTest.
> Myrna suggests checking for and filtering out the exact properties we expect to see to make a better test and make it less fragile.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-4997) SysinfoTest version output filtering
is fragile with new java versions
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-4997:
----------------------------------
Attachment: derby-4997_diff.txt
Here is the patch I would like to commit for this issue. The sed method has been removed and now the tests just checks for the strings that it needs to check in the output without failing if the number of lines change.
> SysinfoTest version output filtering is fragile with new java versions
> -----------------------------------------------------------------------
>
> Key: DERBY-4997
> URL: https://issues.apache.org/jira/browse/DERBY-4997
> Project: Derby
> Issue Type: Bug
> Components: Test
> Reporter: Kathey Marsden
> Priority: Minor
> Attachments: derby-4997_diff.txt, derby-4997_notforcommit.txt
>
>
> Some newer java version output may have lines lines that are not filtered out by the existing SysinfoTest.
> Myrna suggests checking for and filtering out the exact properties we expect to see to make a better test and make it less fragile.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (DERBY-4997) SysinfoTest version output filtering
is fragile with new java versions
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden closed DERBY-4997.
---------------------------------
Resolution: Fixed
Fix Version/s: 10.8.0.0
10.7.1.3
10.6.2.3
10.5.3.2
Issue & fix info: [Newcomer] (was: [Patch Available, Newcomer])
> SysinfoTest version output filtering is fragile with new java versions
> -----------------------------------------------------------------------
>
> Key: DERBY-4997
> URL: https://issues.apache.org/jira/browse/DERBY-4997
> Project: Derby
> Issue Type: Bug
> Components: Test
> Reporter: Kathey Marsden
> Priority: Minor
> Fix For: 10.5.3.2, 10.6.2.3, 10.7.1.3, 10.8.0.0
>
> Attachments: derby-4997_diff.txt, derby-4997_notforcommit.txt
>
>
> Some newer java version output may have lines lines that are not filtered out by the existing SysinfoTest.
> Myrna suggests checking for and filtering out the exact properties we expect to see to make a better test and make it less fragile.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira