You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/06/20 03:03:20 UTC
Review Request 35679: Added benchmark test for
Allocator::updateSlave().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35679/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Jie Yu.
Bugs: MESOS-2891
https://issues.apache.org/jira/browse/MESOS-2891
Repository: mesos
Description
-------
updateSlave() is really slow. See numbers below.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp d2f65d79160698463b47442523ced39f9c4636c0
Diff: https://reviews.apache.org/r/35679/diff/
Testing
-------
make check
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/0
Added 1000 slaves in 766.99568ms
Updated 1000 slaves in 6.807111421secs
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/0 (7751 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/1
Added 5000 slaves in 3.886493374secs
Updated 5000 slaves in 4.07753897601667mins
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/1 (249472 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/2
Added 10000 slaves in 7.720996758secs
Updated 10000 slaves in 16.4897123807167mins
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/2 (999001 ms)
Thanks,
Vinod Kone
Re: Review Request 35679: Added benchmark test for
Allocator::updateSlave().
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35679/#review88616
-----------------------------------------------------------
Ship it!
src/tests/hierarchical_allocator_tests.cpp (line 989)
<https://reviews.apache.org/r/35679/#comment141208>
s/UpdateSlave/AddAndUpdateSlave/ ?
- Jie Yu
On June 20, 2015, 1:03 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35679/
> -----------------------------------------------------------
>
> (Updated June 20, 2015, 1:03 a.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Bugs: MESOS-2891
> https://issues.apache.org/jira/browse/MESOS-2891
>
>
> Repository: mesos
>
>
> Description
> -------
>
> updateSlave() is really slow. See numbers below.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp d2f65d79160698463b47442523ced39f9c4636c0
>
> Diff: https://reviews.apache.org/r/35679/diff/
>
>
> Testing
> -------
>
> make check
>
> [ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/0
> Added 1000 slaves in 766.99568ms
> Updated 1000 slaves in 6.807111421secs
> [ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/0 (7751 ms)
> [ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/1
> Added 5000 slaves in 3.886493374secs
> Updated 5000 slaves in 4.07753897601667mins
> [ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/1 (249472 ms)
> [ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/2
> Added 10000 slaves in 7.720996758secs
> Updated 10000 slaves in 16.4897123807167mins
> [ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/2 (999001 ms)
>
>
> Thanks,
>
> Vinod Kone
>
>