You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/12/16 18:29:26 UTC
[GitHub] [phoenix-queryserver] vdiravka opened a new pull request #80: PHOENIX-6613 QueryServerBasicsIT usage by external tools
vdiravka opened a new pull request #80:
URL: https://github.com/apache/phoenix-queryserver/pull/80
QueryServerBasicsIT is a public class which can allow testing PQS in external tools.
It is possible to setup PQS, but there is no possibility to connect to it withDriverManager.getConnection(CONN_STRING), because there is no getter for CONN_STRING.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-queryserver] stoty commented on pull request #80: PHOENIX-6613 QueryServerBasicsIT usage by external tools
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #80:
URL: https://github.com/apache/phoenix-queryserver/pull/80#issuecomment-1074893759
I've committed the change without the changes that result in too long lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-queryserver] stoty commented on a change in pull request #80: PHOENIX-6613 QueryServerBasicsIT usage by external tools
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #80:
URL: https://github.com/apache/phoenix-queryserver/pull/80#discussion_r831055135
##########
File path: phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/server/QueryServer.java
##########
@@ -340,12 +340,10 @@ void configureSpnegoAuthentication(HttpServer.Builder builder, UserGroupInformat
* the configured principal as-is if {@code _HOST} is not the "instance".
*/
String getSpnegoPrincipal(Configuration conf) throws IOException {
- String httpPrincipal = conf.get(
- QueryServerProperties.QUERY_SERVER_KERBEROS_HTTP_PRINCIPAL_ATTRIB, null);
+ String httpPrincipal = conf.get(QueryServerProperties.QUERY_SERVER_KERBEROS_HTTP_PRINCIPAL_ATTRIB, null);
// Backwards compat for a configuration key change
if (httpPrincipal == null) {
- httpPrincipal = conf.get(
- QueryServerProperties.QUERY_SERVER_KERBEROS_HTTP_PRINCIPAL_ATTRIB_LEGACY, null);
+ httpPrincipal = conf.get(QueryServerProperties.QUERY_SERVER_KERBEROS_HTTP_PRINCIPAL_ATTRIB_LEGACY, null);
Review comment:
Same as above.
##########
File path: phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/server/QueryServer.java
##########
@@ -340,12 +340,10 @@ void configureSpnegoAuthentication(HttpServer.Builder builder, UserGroupInformat
* the configured principal as-is if {@code _HOST} is not the "instance".
*/
String getSpnegoPrincipal(Configuration conf) throws IOException {
- String httpPrincipal = conf.get(
- QueryServerProperties.QUERY_SERVER_KERBEROS_HTTP_PRINCIPAL_ATTRIB, null);
+ String httpPrincipal = conf.get(QueryServerProperties.QUERY_SERVER_KERBEROS_HTTP_PRINCIPAL_ATTRIB, null);
Review comment:
These changes result in lines longer than 100 characters.
Please revert them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-queryserver] stoty closed pull request #80: PHOENIX-6613 QueryServerBasicsIT usage by external tools
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #80:
URL: https://github.com/apache/phoenix-queryserver/pull/80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org