You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Kalyani Kashikar <ka...@freestoneinfotech.com> on 2017/06/29 10:56:27 UTC

Review Request 60534: UI - Render HTML element based on attribute data-type while assigning Tag to entity.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60534/
-----------------------------------------------------------

Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.


Bugs: ATLAS-1897
    https://issues.apache.org/jira/browse/ATLAS-1897


Repository: atlas


Description
-------

While assigning tag to entity, It allows inputs based on attribute data-type.


Note -This patch is dependent on ATLAS-1894.


Diffs
-----

  dashboardv2/public/js/views/tag/addTagModalView.js 7eaf23c 


Diff: https://reviews.apache.org/r/60534/diff/1/


Testing
-------

Validation for all input field has been verified.


Thanks,

Kalyani Kashikar


Re: Review Request 60534: UI - Render HTML element based on attribute data-type while assigning Tag to entity.

Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60534/#review179548
-----------------------------------------------------------


Ship it!




Ship It!

- Nixon Rodrigues


On June 29, 2017, 10:56 a.m., Kalyani Kashikar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60534/
> -----------------------------------------------------------
> 
> (Updated June 29, 2017, 10:56 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-1897
>     https://issues.apache.org/jira/browse/ATLAS-1897
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> While assigning tag to entity, It allows inputs based on attribute data-type.
> 
> 
> Note -This patch is dependent on ATLAS-1894.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/views/tag/addTagModalView.js 7eaf23c 
> 
> 
> Diff: https://reviews.apache.org/r/60534/diff/1/
> 
> 
> Testing
> -------
> 
> Validation for all input field has been verified.
> 
> 
> Thanks,
> 
> Kalyani Kashikar
> 
>