You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by emmanuelnnaa <gi...@git.apache.org> on 2016/08/08 14:21:03 UTC
[GitHub] incubator-fineract pull request #199: commit for FINERACT-72 (Speed up the r...
GitHub user emmanuelnnaa opened a pull request:
https://github.com/apache/incubator-fineract/pull/199
commit for FINERACT-72 (Speed up the retrieval of journal entries when 'transactionDetails' is set to true)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/emmanuelnnaa/incubator-fineract FINERACT-72
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-fineract/pull/199.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #199
----
commit 1dc59e29a790f1246b39f084bfff9816db50659e
Author: Emmanuel Nnaa <em...@musoni.eu>
Date: 2016-08-08T14:20:13Z
commit for FINERACT-72 (Speed up the retrieval of journal entries when 'transactionDetails' is set to true)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #199: commit for FINERACT-72 (Speed up the r...
Posted by emmanuelnnaa <gi...@git.apache.org>.
Github user emmanuelnnaa closed the pull request at:
https://github.com/apache/incubator-fineract/pull/199
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #199: commit for FINERACT-72 (Speed up the r...
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/199#discussion_r74540171
--- Diff: fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccountingProcessorHelper.java ---
@@ -909,12 +911,13 @@ private void createDebitJournalEntryForSavings(final Office office, final String
LoanTransaction loanTransaction = null;
SavingsAccountTransaction savingsAccountTransaction = null;
ClientTransaction clientTransaction = null;
- final PaymentDetail paymentDetail = null;
+ PaymentDetail paymentDetail = null;
final Long shareTransactionId = null;
String modifiedTransactionId = transactionId;
if (StringUtils.isNumeric(transactionId)) {
long id = Long.parseLong(transactionId);
savingsAccountTransaction = this.savingsAccountTransactionRepository.findOne(id);
+ paymentDetail = this.savingsAccountTransactionRepository.findOne(id).getPaymentDetail();
--- End diff --
unnecessary repository call. You can make use of savingsAccountTransaction object to retrieve payment details
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #199: commit for FINERACT-72 (Speed up the r...
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/199#discussion_r74540164
--- Diff: fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccountingProcessorHelper.java ---
@@ -889,12 +890,13 @@ private void createDebitJournalEntryForLoan(final Office office, final String cu
LoanTransaction loanTransaction = null;
SavingsAccountTransaction savingsAccountTransaction = null;
ClientTransaction clientTransaction = null;
- final PaymentDetail paymentDetail = null;
+ PaymentDetail paymentDetail = null;
final Long shareTransactionId = null;
String modifiedTransactionId = transactionId;
if (StringUtils.isNumeric(transactionId)) {
long id = Long.parseLong(transactionId);
loanTransaction = this.loanTransactionRepository.findOne(id);
+ paymentDetail = this.loanTransactionRepository.findOne(id).getPaymentDetail();
--- End diff --
unnecessary repository call. You can make use of loanTransaction object to retrieve payment details
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #199: commit for FINERACT-72 (Speed up the r...
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/199#discussion_r74540135
--- Diff: fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccountingProcessorHelper.java ---
@@ -820,11 +820,12 @@ private void createCreditJournalEntryForSavings(final Office office, final Strin
SavingsAccountTransaction savingsAccountTransaction = null;
ClientTransaction clientTransaction = null;
final Long shareTransactionId = null;
- final PaymentDetail paymentDetail = null;
+ PaymentDetail paymentDetail = null;
String modifiedTransactionId = transactionId;
if (StringUtils.isNumeric(transactionId)) {
long id = Long.parseLong(transactionId);
savingsAccountTransaction = this.savingsAccountTransactionRepository.findOne(id);
+ paymentDetail = this.savingsAccountTransactionRepository.findOne(id).getPaymentDetail();
--- End diff --
unnecessary repository call. You can make use of savingsAccountTransaction object to retrieve payment details
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---