You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/08/24 05:11:05 UTC

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42643: [SPARK-44121][CONNECT][TESTS] Renable Arrow-based connect tests in Java 21

dongjoon-hyun commented on code in PR #42643:
URL: https://github.com/apache/spark/pull/42643#discussion_r1303810057


##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/RemoteSparkSession.scala:
##########
@@ -230,17 +225,4 @@ trait RemoteSparkSession extends ConnectFunSuite with BeforeAndAfterAll {
     spark = null
     super.afterAll()
   }
-
-  /**
-   * SPARK-44259: override test function to skip `RemoteSparkSession-based` tests as default, we
-   * should delete this function after SPARK-44121 is completed.
-   */
-  override protected def test(testName: String, testTags: Tag*)(testFun: => Any)(implicit

Review Comment:
   No problem at all. Thank you for review!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org