[GitHub] tysonnorris commented on a change in pull request #2957: splunk logstore

[GitBox <gi...@apache.org>]

tysonnorris commented on a change in pull request #2957: splunk logstore
URL: https://github.com/apache/incubator-openwhisk/pull/2957#discussion_r167372273
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/containerpool/logging/SplunkLogStore.scala
 ##########
 @@ -100,8 +100,8 @@ class SplunkLogStore(
         "exec_mode" -> "oneshot",
         "search" -> search,
         "output_mode" -> "json",
-        "earliest_time" -> formatter.format(activation.start),
-        "latest_time" -> formatter.format(activation.end))).toEntity
 
 Review comment:
   I originally had this in there to limit the time range as much as possible for the splunk query, since the activation may have run days ago, lasted 10ms, and there may be millions of log events since then. 
   I'm not positive that splunk does better with a narrower time range, but I assumed it does - WDYT? 
   I could add it back in, but with end time + 5s to avoid any issues with collecting logs on short activations?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services