You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Harsh J (JIRA)" <ji...@apache.org> on 2011/09/21 13:45:10 UTC
[jira] [Created] (HBASE-4451) Improve zk node naming
(/hbase/shutdown)
Improve zk node naming (/hbase/shutdown)
----------------------------------------
Key: HBASE-4451
URL: https://issues.apache.org/jira/browse/HBASE-4451
Project: HBase
Issue Type: Improvement
Components: master
Affects Versions: 0.94.0
Reporter: Harsh J
Assignee: Harsh J
Priority: Minor
Fix For: 0.94.0
Right now the node {{/hbase/shutdown}} is used to indicate cluster status (cluster up, cluster down).
However, upon a chat with Lars George today, we feel that having a name {{/hbase/shutdown}} is possibly bad. The {{/hbase/shutdown}} zknode contains a date when the cluster was _started_. Now that is difficult to understand and digest, given that a person may connect to zk and try to look at what it is about (they may think it 'shutdown' at that date.).
I feel a better name may simply be: {{/hbase/running}}. Thoughts?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4451) Improve zk node naming
(/hbase/shutdown)
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109654#comment-13109654 ]
stack commented on HBASE-4451:
------------------------------
I'm +1 on changing name and for making whats under the zk node up in zk coherent (you should be discouraged tinkering... but I'd think looking is fine).
> Improve zk node naming (/hbase/shutdown)
> ----------------------------------------
>
> Key: HBASE-4451
> URL: https://issues.apache.org/jira/browse/HBASE-4451
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Fix For: 0.94.0
>
>
> Right now the node {{/hbase/shutdown}} is used to indicate cluster status (cluster up, cluster down).
> However, upon a chat with Lars George today, we feel that having a name {{/hbase/shutdown}} is possibly bad. The {{/hbase/shutdown}} zknode contains a date when the cluster was _started_. Now that is difficult to understand and digest, given that a person may connect to zk and try to look at what it is about (they may think it 'shutdown' at that date.).
> I feel a better name may simply be: {{/hbase/running}}. Thoughts?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4451) Improve zk node naming
(/hbase/shutdown)
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4451:
-------------------------
Tags: noob
Labels: noob (was: )
Marking as noob. If we are going to do this rename, 0.96 is the time to do it.
> Improve zk node naming (/hbase/shutdown)
> ----------------------------------------
>
> Key: HBASE-4451
> URL: https://issues.apache.org/jira/browse/HBASE-4451
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Labels: noob
> Fix For: 0.96.0
>
>
> Right now the node {{/hbase/shutdown}} is used to indicate cluster status (cluster up, cluster down).
> However, upon a chat with Lars George today, we feel that having a name {{/hbase/shutdown}} is possibly bad. The {{/hbase/shutdown}} zknode contains a date when the cluster was _started_. Now that is difficult to understand and digest, given that a person may connect to zk and try to look at what it is about (they may think it 'shutdown' at that date.).
> I feel a better name may simply be: {{/hbase/running}}. Thoughts?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4451) Improve zk node naming
(/hbase/shutdown)
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4451:
-------------------------
Priority: Major (was: Minor)
> Improve zk node naming (/hbase/shutdown)
> ----------------------------------------
>
> Key: HBASE-4451
> URL: https://issues.apache.org/jira/browse/HBASE-4451
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Labels: noob
> Fix For: 0.96.0
>
>
> Right now the node {{/hbase/shutdown}} is used to indicate cluster status (cluster up, cluster down).
> However, upon a chat with Lars George today, we feel that having a name {{/hbase/shutdown}} is possibly bad. The {{/hbase/shutdown}} zknode contains a date when the cluster was _started_. Now that is difficult to understand and digest, given that a person may connect to zk and try to look at what it is about (they may think it 'shutdown' at that date.).
> I feel a better name may simply be: {{/hbase/running}}. Thoughts?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4451) Improve zk node naming
(/hbase/shutdown)
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-4451:
---------------------------------
Fix Version/s: (was: 0.94.0)
0.96.0
Moving out of 0.94.
> Improve zk node naming (/hbase/shutdown)
> ----------------------------------------
>
> Key: HBASE-4451
> URL: https://issues.apache.org/jira/browse/HBASE-4451
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Fix For: 0.96.0
>
>
> Right now the node {{/hbase/shutdown}} is used to indicate cluster status (cluster up, cluster down).
> However, upon a chat with Lars George today, we feel that having a name {{/hbase/shutdown}} is possibly bad. The {{/hbase/shutdown}} zknode contains a date when the cluster was _started_. Now that is difficult to understand and digest, given that a person may connect to zk and try to look at what it is about (they may think it 'shutdown' at that date.).
> I feel a better name may simply be: {{/hbase/running}}. Thoughts?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4451) Improve zk node naming
(/hbase/shutdown)
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109652#comment-13109652 ]
Andrew Purtell commented on HBASE-4451:
---------------------------------------
bq. [...] given that a person may connect to zk and try to look at what it is about [...]
Shouldn't that be discouraged? ("There are no user serviceable parts inside.")
> Improve zk node naming (/hbase/shutdown)
> ----------------------------------------
>
> Key: HBASE-4451
> URL: https://issues.apache.org/jira/browse/HBASE-4451
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Fix For: 0.94.0
>
>
> Right now the node {{/hbase/shutdown}} is used to indicate cluster status (cluster up, cluster down).
> However, upon a chat with Lars George today, we feel that having a name {{/hbase/shutdown}} is possibly bad. The {{/hbase/shutdown}} zknode contains a date when the cluster was _started_. Now that is difficult to understand and digest, given that a person may connect to zk and try to look at what it is about (they may think it 'shutdown' at that date.).
> I feel a better name may simply be: {{/hbase/running}}. Thoughts?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4451) Improve zk node naming
(/hbase/shutdown)
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112155#comment-13112155 ]
Jonathan Gray commented on HBASE-4451:
--------------------------------------
bq. Would changing this have an effect on compatibility?
If you wanted to support this change over a rolling restart or anything like that, it would probably be rather complicated or impractical. So it would require a full restart of the cluster most likely. In addition, any external ops/monitoring/admin tools people have built might be looking at the specific names. That shouldn't necessarily stop us though.
Perhaps we can do this as part of a fresh look at the names of the ZK nodes in general. We might make some changes with the root node and such as well in 94. Do you want to look at all the ZK node names and see if there's a new scheme that would be more clear?
> Improve zk node naming (/hbase/shutdown)
> ----------------------------------------
>
> Key: HBASE-4451
> URL: https://issues.apache.org/jira/browse/HBASE-4451
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Fix For: 0.94.0
>
>
> Right now the node {{/hbase/shutdown}} is used to indicate cluster status (cluster up, cluster down).
> However, upon a chat with Lars George today, we feel that having a name {{/hbase/shutdown}} is possibly bad. The {{/hbase/shutdown}} zknode contains a date when the cluster was _started_. Now that is difficult to understand and digest, given that a person may connect to zk and try to look at what it is about (they may think it 'shutdown' at that date.).
> I feel a better name may simply be: {{/hbase/running}}. Thoughts?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4451) Improve zk node naming
(/hbase/shutdown)
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J reassigned HBASE-4451:
------------------------------
Assignee: (was: Harsh J)
Sorry I left these assigned to me for long. I may pick it up again later, but unassigning for now to allow others.
> Improve zk node naming (/hbase/shutdown)
> ----------------------------------------
>
> Key: HBASE-4451
> URL: https://issues.apache.org/jira/browse/HBASE-4451
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Labels: noob
> Fix For: 0.96.0
>
>
> Right now the node {{/hbase/shutdown}} is used to indicate cluster status (cluster up, cluster down).
> However, upon a chat with Lars George today, we feel that having a name {{/hbase/shutdown}} is possibly bad. The {{/hbase/shutdown}} zknode contains a date when the cluster was _started_. Now that is difficult to understand and digest, given that a person may connect to zk and try to look at what it is about (they may think it 'shutdown' at that date.).
> I feel a better name may simply be: {{/hbase/running}}. Thoughts?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4451) Improve zk node naming
(/hbase/shutdown)
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109681#comment-13109681 ]
Harsh J commented on HBASE-4451:
--------------------------------
Andrew - Agreed. Am not looking to encourage this, btw.
Just that, if its a node without which HBase shuts down, (loosely speaking) the condition shouldn't look like {{if !shutdown: shutdown()}}, but may look like {{if !running: shutdown()}} for better maintainability (code-wise).
Would changing this have an effect on compatibility? I'd like to change it, but would hate to break any things you know would to possibly be monitoring this?
> Improve zk node naming (/hbase/shutdown)
> ----------------------------------------
>
> Key: HBASE-4451
> URL: https://issues.apache.org/jira/browse/HBASE-4451
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Fix For: 0.94.0
>
>
> Right now the node {{/hbase/shutdown}} is used to indicate cluster status (cluster up, cluster down).
> However, upon a chat with Lars George today, we feel that having a name {{/hbase/shutdown}} is possibly bad. The {{/hbase/shutdown}} zknode contains a date when the cluster was _started_. Now that is difficult to understand and digest, given that a person may connect to zk and try to look at what it is about (they may think it 'shutdown' at that date.).
> I feel a better name may simply be: {{/hbase/running}}. Thoughts?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira