You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2021/08/25 19:23:56 UTC
[GitHub] [buildstream] nanonyme opened a new pull request #1502: Fix click deprecation warning for get_terminal_size
nanonyme opened a new pull request #1502:
URL: https://github.com/apache/buildstream/pull/1502
shutil replacement is available since Python 3.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1502: Fix click deprecation warning for get_terminal_size
Posted by GitBox <gi...@apache.org>.
nanonyme commented on pull request #1502:
URL: https://github.com/apache/buildstream/pull/1502#issuecomment-912564846
@gtristan looks like it's now just pending approval for workflow to run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1502: Fix click deprecation warning for get_terminal_size
Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1502:
URL: https://github.com/apache/buildstream/pull/1502#issuecomment-912680888
Yes, that’ll be `pytest-xdist` which sometimes causes crashes.
thanks for pointing out it is caused by timeouts using sigalarm! Maybe we can finally fix that :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1502: Fix click deprecation warning for get_terminal_size
Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1502:
URL: https://github.com/apache/buildstream/pull/1502#issuecomment-912681268
Do we need this patch on master also ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1502: Fix click deprecation warning for get_terminal_size
Posted by GitBox <gi...@apache.org>.
nanonyme commented on pull request #1502:
URL: https://github.com/apache/buildstream/pull/1502#issuecomment-912638572
@gtristan are we using threading with py.test? It looks like bst1 tests use child threads and timeout constructs through signals which are imcompatible with each other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme edited a comment on pull request #1502: Fix click deprecation warning for get_terminal_size
Posted by GitBox <gi...@apache.org>.
nanonyme edited a comment on pull request #1502:
URL: https://github.com/apache/buildstream/pull/1502#issuecomment-912638572
@gtristan are we using threading with py.test? It looks like bst1 tests use child threads and timeout constructs through signals which are imcompatible with each other. There was just very exotic stack trace on Debian 10 as a result of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1502: Fix click deprecation warning for get_terminal_size
Posted by GitBox <gi...@apache.org>.
nanonyme commented on pull request #1502:
URL: https://github.com/apache/buildstream/pull/1502#issuecomment-912686003
Oh, oops. it's in two different places also with bst-1. I'll create a new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1502: Fix click deprecation warning for get_terminal_size
Posted by GitBox <gi...@apache.org>.
nanonyme commented on pull request #1502:
URL: https://github.com/apache/buildstream/pull/1502#issuecomment-912685585
Apparently yes. The same problem is in master https://github.com/apache/buildstream/blob/a935429a8089b12e46a0257372efedd4fa13dbb7/src/buildstream/_frontend/status.py#L67 and https://github.com/apache/buildstream/blob/a935429a8089b12e46a0257372efedd4fa13dbb7/src/buildstream/_frontend/status.py#L219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1502: Fix click deprecation warning for get_terminal_size
Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1502:
URL: https://github.com/apache/buildstream/pull/1502#issuecomment-912569928
Looks like CI is working and the lint check failed for the import ordering check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme edited a comment on pull request #1502: Fix click deprecation warning for get_terminal_size
Posted by GitBox <gi...@apache.org>.
nanonyme edited a comment on pull request #1502:
URL: https://github.com/apache/buildstream/pull/1502#issuecomment-912584237
Force pushed re-ordering and added newline to make it more clear where standard library imports end. I don't know why tests are failing on Ubuntu 18.04.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan merged pull request #1502: Fix click deprecation warning for get_terminal_size
Posted by GitBox <gi...@apache.org>.
gtristan merged pull request #1502:
URL: https://github.com/apache/buildstream/pull/1502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1502: Fix click deprecation warning for get_terminal_size
Posted by GitBox <gi...@apache.org>.
nanonyme commented on pull request #1502:
URL: https://github.com/apache/buildstream/pull/1502#issuecomment-912584237
Force pushed re-ordering. I don't know why tests are failing on Ubuntu 18.04.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1502: Fix click deprecation warning for get_terminal_size
Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1502:
URL: https://github.com/apache/buildstream/pull/1502#issuecomment-912422599
Can you rebase this and see if the CI is now working from forks ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme edited a comment on pull request #1502: Fix click deprecation warning for get_terminal_size
Posted by GitBox <gi...@apache.org>.
nanonyme edited a comment on pull request #1502:
URL: https://github.com/apache/buildstream/pull/1502#issuecomment-912584237
Force pushed re-ordering and added newline to make it more clear where standard library imports end. I don't know why tests are failing on Ubuntu 18.04. Looks like since I'm still considered first-time contributor, another workflow approval is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org