[GitHub] [maven-scripting-plugin] rmannibucau commented on a change in pull request #4: [MSCRIPTING-7] binding the session and servers helper in binding context

[GitBox <gi...@apache.org>]

rmannibucau commented on a change in pull request #4:
URL: https://github.com/apache/maven-scripting-plugin/pull/4#discussion_r684098220



##########
File path: src/main/java/org/apache/maven/plugins/scripting/EvalMojo.java
##########
@@ -73,8 +84,10 @@ public void execute()
          AbstractScriptEvaluator execute = constructExecute();
 
          Bindings bindings = new SimpleBindings();
+         bindings.put( "session", session );
          bindings.put( "project", project );
          bindings.put( "log", getLog() );
+         bindings.put( "servers", new Servers( session, settingsDecrypter ) );

Review comment:
       Do we have it already? I would like to avoid to decipher the whole settings each time (this is done only when needed) because it can slow down the execution a loooot for nothing in practise.
   Happy to wrap it in a MavenScripting wrapper which would expose this kind of API (so script would use mavenScripting.servers.find(...))




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org