You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/18 14:03:27 UTC

[GitHub] [pulsar] codelipenghui commented on a change in pull request #6034: [Pulsar IO][Issue 5633]Support avro schema for debezium connector

codelipenghui commented on a change in pull request #6034: [Pulsar IO][Issue 5633]Support avro schema for debezium connector
URL: https://github.com/apache/pulsar/pull/6034#discussion_r410701387
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/generic/GenericAvroReader.java
 ##########
 @@ -47,6 +47,10 @@
     private final List<Field> fields;
     private final Schema schema;
     private final byte[] schemaVersion;
+
+    private int offset;
+    public final static String OFFSET_PROP = "AVRO_READ_OFFSET";
 
 Review comment:
   There are two properties name definition in the `SchemaDefinitionBuilderImpl`.  I think you can move all of them to `SchemaDefinition` and keep the with prefix "__".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services