You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/03 22:02:22 UTC
[GitHub] [kafka] mtillu opened a new pull request #8797: Fixing KAFKA-10094
mtillu opened a new pull request #8797:
URL: https://github.com/apache/kafka/pull/8797
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mtillu commented on pull request #8797: Fixing KAFKA-10094
Posted by GitBox <gi...@apache.org>.
mtillu commented on pull request #8797:
URL: https://github.com/apache/kafka/pull/8797#issuecomment-639604280
PTAL @jghoman - Looks like all tests have passed and we are ready for a merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mtillu commented on pull request #8797: Fixing KAFKA-10094
Posted by GitBox <gi...@apache.org>.
mtillu commented on pull request #8797:
URL: https://github.com/apache/kafka/pull/8797#issuecomment-638485010
PTAL @jghoman
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jghoman commented on pull request #8797: Fixing KAFKA-10094
Posted by GitBox <gi...@apache.org>.
jghoman commented on pull request #8797:
URL: https://github.com/apache/kafka/pull/8797#issuecomment-639880111
Thanks for the contribution, @mtillu !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8797: Fixing KAFKA-10094
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8797:
URL: https://github.com/apache/kafka/pull/8797#issuecomment-638549876
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jghoman merged pull request #8797: Fixing KAFKA-10094
Posted by GitBox <gi...@apache.org>.
jghoman merged pull request #8797:
URL: https://github.com/apache/kafka/pull/8797
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mtillu commented on pull request #8797: Fixing KAFKA-10094
Posted by GitBox <gi...@apache.org>.
mtillu commented on pull request #8797:
URL: https://github.com/apache/kafka/pull/8797#issuecomment-640097211
> Thanks for the contribution! Can we please follow the guidelines as described here for future contributions?
>
> https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
>
> In particular, the PR/commit title should be "KAFKA-10094: In MirrorSourceConnector replace two-step assignment with single call".
>
> Also, we generally include a "Reviewers: " line in the commit message @jghoman.
>
> Thanks once again.
Thanks for the pointers Ismael, I will!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8797: Fixing KAFKA-10094
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8797:
URL: https://github.com/apache/kafka/pull/8797#issuecomment-639916804
Thanks for the contribution! Can we please follow the guidelines as described here for future contributions?
https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
In particular, the PR/commit title should be "KAFKA-10094: In MirrorSourceConnector replace two-step assignment with single call".
Also, we generally include a "Reviewers: " line in the commit message @jghoman.
Thanks once again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org