You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "jerpelea (via GitHub)" <gi...@apache.org> on 2024/10/10 07:46:28 UTC

[PR] Revert "{Bp-2592} lvgl: upgrade to release/v9.2.1" [nuttx-apps]

jerpelea opened a new pull request, #2674:
URL: https://github.com/apache/nuttx-apps/pull/2674

   Reverts apache/nuttx-apps#2670
   revert until LVGL is released


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert "{Bp-2592} lvgl: upgrade to release/v9.2.1" [nuttx-apps]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #2674:
URL: https://github.com/apache/nuttx-apps/pull/2674


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert "{Bp-2592} lvgl: upgrade to release/v9.2.1" [nuttx-apps]

Posted by "jerpelea (via GitHub)" <gi...@apache.org>.
jerpelea commented on PR #2674:
URL: https://github.com/apache/nuttx-apps/pull/2674#issuecomment-2404627516

   @lupyuen  please merge the PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert "{Bp-2592} lvgl: upgrade to release/v9.2.1" [nuttx-apps]

Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #2674:
URL: https://github.com/apache/nuttx-apps/pull/2674#issuecomment-2404343357

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   **Meets Requirements?** 
   
   No.
   
   **Missing Information:**
   
   * **Summary:**  While it mentions reverting a specific PR, it lacks details on *why* this is necessary. Is the LVGL update causing issues? What problems does this revert solve? 
   * **Impact:**  This section is completely empty.  The PR needs to outline the impact on users, builds, hardware, documentation, etc.  Reverting changes can have significant consequences that need to be explained.
   * **Testing:** No testing logs are provided.  Even though this is a revert, you must demonstrate that the revert achieves the desired outcome (e.g., fixes a bug, restores previous functionality).
   
   **Recommendation:**
   
   Expand the PR description to address the missing information. Provide clear explanations and relevant testing logs to ensure the PR is thorough and meets NuttX's requirements. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org