[GitHub] [helix] NealSun96 commented on a diff in pull request #2153: Add AclRegister interfaces and ClusterAccessor integration

[GitBox <gi...@apache.org>]

NealSun96 commented on code in PR #2153:
URL: https://github.com/apache/helix/pull/2153#discussion_r899355529


##########
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java:
##########
@@ -187,6 +189,13 @@ public Response createCluster(@PathParam("clusterId") String clusterId,
       LOG.error("Failed to create cluster {}. Exception: {}.", clusterId, ex);
       return serverError(ex);
     }
+
+    try {

Review Comment:
   Synced offline: we will allow only allow a cluster to be created if the ACL exists, so we are changing the order. 
   
   When creating ACL, we will keep it idempotent, but only for the correct user. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org