You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by dk...@apache.org on 2010/12/27 13:53:06 UTC
Re: svn commit: r1053030 - /cxf/branches/2.3.x-fixes/rt/ws/policy/src/test/java/org/apache/cxf/ws/policy/PolicyAnnotationTest.java
I'm -1 to this as it fixes the wrong thing. We need to find the test that is leaving the bus and make sure the cleanup is done.
Daniel Kulp
http://dankulp.com/blog
On Dec 27, 2010, at 4:37 AM, ningjiang@apache.org wrote:
> Author: ningjiang
> Date: Mon Dec 27 09:37:49 2010
> New Revision: 1053030
>
> URL: http://svn.apache.org/viewvc?rev53030&view=rev
> Log:
> Fix the test failed of PolicyAnnotationTest with JDK1.5
>
> Modified:
> cxf/branches/2.3.x-fixes/rt/ws/policy/src/test/java/org/apache/cxf/ws/policy/PolicyAnnotationTest.java
>
> Modified: cxf/branches/2.3.x-fixes/rt/ws/policy/src/test/java/org/apache/cxf/ws/policy/PolicyAnnotationTest.java
> URL: http://svn.apache.org/viewvc/cxf/branches/2.3.x-fixes/rt/ws/policy/src/test/java/org/apache/cxf/ws/policy/PolicyAnnotationTest.java?rev53030&r153029&r253030&view=diff
> =======================================
> --- cxf/branches/2.3.x-fixes/rt/ws/policy/src/test/java/org/apache/cxf/ws/policy/PolicyAnnotationTest.java (original)
> +++ cxf/branches/2.3.x-fixes/rt/ws/policy/src/test/java/org/apache/cxf/ws/policy/PolicyAnnotationTest.java Mon Dec 27 09:37:49 2010
> @@ -53,6 +53,8 @@ public class PolicyAnnotationTest extend
>
> @org.junit.Test
> public void testAnnotations() throws Exception {
> + // Need to clean up the Default Bus instance frist
> + BusFactory.setDefaultBus(null);
> Bus bus = BusFactory.getDefaultBus();
> JaxWsServerFactoryBean factory = new JaxWsServerFactoryBean();
> factory.setBus(bus);
>
>
Re: svn commit: r1053030 - /cxf/branches/2.3.x-fixes/rt/ws/policy/src/test/java/org/apache/cxf/ws/policy/PolicyAnnotationTest.java
Posted by Willem Jiang <wi...@gmail.com>.
Hi Dan,
I had to admit that the issue is introduced by the new added test
PolicyEngineImplInitTest.
I think you already fix it just before I commit my fix :)
Willem
On 12/27/10 8:53 PM, dkulp@apache.org wrote:
>
>
> I'm -1 to this as it fixes the wrong thing. We need to find the test that is leaving the bus and make sure the cleanup is done.
>
> Daniel Kulp
> http://dankulp.com/blog
>
>
> On Dec 27, 2010, at 4:37 AM, ningjiang@apache.org wrote:
>
>> Author: ningjiang
>> Date: Mon Dec 27 09:37:49 2010
>> New Revision: 1053030
>>
>> URL: http://svn.apache.org/viewvc?rev53030&view=rev
>> Log:
>> Fix the test failed of PolicyAnnotationTest with JDK1.5
>>
>> Modified:
>> cxf/branches/2.3.x-fixes/rt/ws/policy/src/test/java/org/apache/cxf/ws/policy/PolicyAnnotationTest.java
>>
>> Modified: cxf/branches/2.3.x-fixes/rt/ws/policy/src/test/java/org/apache/cxf/ws/policy/PolicyAnnotationTest.java
>> URL: http://svn.apache.org/viewvc/cxf/branches/2.3.x-fixes/rt/ws/policy/src/test/java/org/apache/cxf/ws/policy/PolicyAnnotationTest.java?rev53030&r153029&r253030&view=diff
>> ============================================================================
>> --- cxf/branches/2.3.x-fixes/rt/ws/policy/src/test/java/org/apache/cxf/ws/policy/PolicyAnnotationTest.java (original)
>> +++ cxf/branches/2.3.x-fixes/rt/ws/policy/src/test/java/org/apache/cxf/ws/policy/PolicyAnnotationTest.java Mon Dec 27 09:37:49 2010
>> @@ -53,6 +53,8 @@ public class PolicyAnnotationTest extend
>>
>> @org.junit.Test
>> public void testAnnotations() throws Exception {
>> + // Need to clean up the Default Bus instance frist
>> + BusFactory.setDefaultBus(null);
>> Bus bus =usFactory.getDefaultBus();
>> JaxWsServerFactoryBean factory =ew JaxWsServerFactoryBean();
>> factory.setBus(bus);
>>
>>
>
>
--
Willem
----------------------------------
FuseSource
Web: http://www.fusesource.com
Blog: http://willemjiang.blogspot.com (English)
http://jnn.javaeye.com (Chinese)
Twitter: willemjiang