You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/18 07:58:25 UTC

[GitHub] HeartSaVioR opened a new pull request #23820: [MINOR][CORE][YARN] Redact command line arguments for running Driver and Executor before logging (standalone and YARN)

HeartSaVioR opened a new pull request #23820: [MINOR][CORE][YARN] Redact command line arguments for running Driver and Executor before logging (standalone and YARN)
URL: https://github.com/apache/spark/pull/23820
 
 
   ## What changes were proposed in this pull request?
   
   This patch applies redaction to command line arguments before logging them. This applies to two resource managers: standalone cluster and YARN.
   
   This patch only concerns `-D` option since Spark is likely passing the Spark configuration as `-Dspark.blabla=blabla`. More change is necessary if we also want to handle the case of `--conf spark.blabla=blabla`.
   
   ## How was this patch tested?
   
   Added UT for redact logic. This patch only touches how to log so not easy to add UT regarding it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org