You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/07/24 20:26:56 UTC

[GitHub] [kafka] vvcephei commented on pull request #9074: KAFKA-10287: PROPOSAL: safe offset tracking

vvcephei commented on pull request #9074:
URL: https://github.com/apache/kafka/pull/9074#issuecomment-663719873


   Hey @cadonna , I was reflecting on your fix for KAFKA-10287, and it seems like dealing with those sentinel values is quite risky. We've had several bugs in the past, I don't feel certain that we don't have bugs today, and any refactoring could easily introduce bugs in the future.
   
   What do you think about taking a structural approach to offset sentinel management, like in this proposal?
   
   This wouldn't be for 2.6, but it's targeted at that branch because I built upon your PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org