You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "jeanouii (via GitHub)" <gi...@apache.org> on 2026/01/30 12:24:09 UTC

[PR] Ensure consumer is closed after all acknowledgments are processed [activemq]

jeanouii opened a new pull request, #1643:
URL: https://github.com/apache/activemq/pull/1643

   ACKs are Async and Closing Consumer Too Early Skips Them. The broker's queue statistics (dequeueCount) are the only reliable synchronization point to confirm ACKs were processed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] AMQ-9853 Ensure consumer is closed after all acknowledgments are processed [activemq]

Posted by "jeanouii (via GitHub)" <gi...@apache.org>.
jeanouii commented on PR #1643:
URL: https://github.com/apache/activemq/pull/1643#issuecomment-3824451326

   @cshannon Issue created [AMQ-9853](https://issues.apache.org/jira/browse/AMQ-9853)
   Commit updated and PR title


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] AMQ-9853 Ensure consumer is closed after all acknowledgments are processed [activemq]

Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon merged PR #1643:
URL: https://github.com/apache/activemq/pull/1643


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] AMQ-9853 Ensure consumer is closed after all acknowledgments are processed [activemq]

Posted by "gemmellr (via GitHub)" <gi...@apache.org>.
gemmellr commented on PR #1643:
URL: https://github.com/apache/activemq/pull/1643#issuecomment-3852789499

   This seems more like a potential client bug the test was catching but no longer will. Calling close from another thread is meant to wait for an in progress onMessage delivery to complete, so there doesnt appear to be a legitimate race in the original test code calling close after the latch was tripped due to receiving the final message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] Ensure consumer is closed after all acknowledgments are processed [activemq]

Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on PR #1643:
URL: https://github.com/apache/activemq/pull/1643#issuecomment-3824371088

   Is there an associated test Jira with this? The test failures seem unrelated of course so I think it can be merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact