[GitHub] yifeih edited a comment on issue #23914: [SPARK-27009] Add Standard Deviation to Benchmark tests

[GitBox <gi...@apache.org>]

yifeih edited a comment on issue #23914: [SPARK-27009] Add Standard Deviation to Benchmark tests
URL: https://github.com/apache/spark/pull/23914#issuecomment-468084289
 
 
   Maybe more context: 
   We're making the changes in the palantir/spark repo now because it's already integrated with CircleCI's containerized build systems and makes it easier to test. Everything else in the PR is related to the specific shuffle code that we plan on refactoring for SPARK-25299, but I thought maybe this was something I could pull out since it seemed generally useful to have. 
   
   Eventually, the goal is to merge the refactoring changes for SPARK-25299 upstream. The benchmarks can be part of the merge upstream, but don't necessarily have to. Their biggest purpose is to catch performance changes early on during the development process

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org